Add preference lookups by height to the consensus interface #2092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Sep 24, 2023
StephenButtolph
commented
Sep 24, 2023
| @@ -251,7 +271,7 @@ func (ts *Topological) Preference() ids.ID { | |||
| // unsuccessful poll on that block and every descendant block. | |||
| // | |||
| // The complexity of this function is: | |||
| // - Runtime = 3 * |live set| + |votes| | |||
| // - Runtime = 4 * |live set| + |votes| | |||
There was a problem hiding this comment.
Because of the additional map iteration caused by maps.Clear
gyuho
approved these changes
Sep 25, 2023
joshua-kim
approved these changes
Sep 26, 2023
danlaine
reviewed
Sep 26, 2023
danlaine
approved these changes
Sep 26, 2023
Co-authored-by: Dan Laine <daniel.laine@avalabs.org> Signed-off-by: Stephen Buttolph <stephen@avalabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The bubbling votes optimization requires the ability to lookup the preferred value at a given height.
How this works
In the same locations that we currently populate the
preferredIDsset - we now populate a new mappreferredHeightsas well.How this was tested
Added checks to various existing preference unit tests.