MerkleDB Adjust New View function(s) #1927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dboehm-avalabs
commented
Aug 25, 2023
| @@ -38,7 +38,6 @@ const ( | |||
| ) | |||
|
|
|||
| var ( | |||
| _ TrieView = (*merkleDB)(nil) | |||
There was a problem hiding this comment.
No longer needed.
4 tasks
StephenButtolph
approved these changes
Aug 27, 2023
Comment on lines
-683
to
-685
| if db.closed { | ||
| return nil, database.ErrClosed | ||
| } |
There was a problem hiding this comment.
Kind of weird that this was removed - but because this is an internal function it makes sense that this should never really happen anyways
There was a problem hiding this comment.
we always check it before we call this function, so it couldn't really happen as you said.
…avalanchego into MerkleDBAlternativeConstructor
StephenButtolph
approved these changes
Aug 27, 2023
patrick-ogrady
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new map based NewView function which is easier to use for some callers. Add bool to both NewView functions to allow caller to specify if it is safe to not copy the []byte values. If it is safe to not copy, this unlocks a performance increase due to less allocations and copies.