Remove optional height indexing interface #1896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Aug 23, 2023
| @@ -18,7 +18,7 @@ jobs: | |||
| with: | |||
| go-version: '~1.19.12' | |||
| check-latest: true | |||
| - uses: bufbuild/buf-setup-action@v1.23.1 | |||
| - uses: bufbuild/buf-setup-action@v1.26.1 | |||
There was a problem hiding this comment.
Could be factored out - but did this because the brew tap only includes the latest version
Comment on lines
+111
to
+112
| ERROR_HEIGHT_INDEX_INCOMPLETE = 3; | ||
| ERROR_STATE_SYNC_NOT_IMPLEMENTED = 4; |
There was a problem hiding this comment.
Note: requires version bump
There was a problem hiding this comment.
We always just bump the rpcchainvm version anyways - so no need for compatibility at the proto level.
StephenButtolph
added
vm
StephenButtolph
requested review from
hexfusion,
danlaine and
gyuho
as code owners
abi87
reviewed
Aug 24, 2023
| // ErrIndexIncomplete is used to indicate that the VM is currently repairing its | ||
| // index. | ||
| // | ||
| // TODO: Remove after v1.11.x activates. |
There was a problem hiding this comment.
just reasoning aloud here: is this true even for the ProposerVM? I mean once we're sure that any VM will implement its height index, there won't be cases there proposerVM height index can be incomplete (following a successful initialization)?
There was a problem hiding this comment.
The index can still be repaired async until v1.11.x
abi87
approved these changes
Aug 24, 2023
darioush
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
All VMs now implement height indexing - so we can add the methods to the VM interface.
How this works
Moves methods from the
HeightIndexedChainVMinterface to the `ChainVM interface.How this was tested
CI