RewardValidatorTx cleanup #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

StephenButtolph merged 33 commits into dev from reward_tx_refactoring

Sep 19, 2023

Contributor

abi87 commented Aug 22, 2023 •

edited

Loading

Why this should be merged

It just breaks handling of RewardValidatorTx into smaller pieces, that are more easily upgraded for continuous staking changes.

How this works

Just refactoring

How this was tested

CI


          rewardValidatorTx cleanup

68570c7

abi87 self-assigned this

abi87 added the continuous staking label

abi87 commented

View reviewed changes

vms/platformvm/txs/executor/staker_tx_verification.go Show resolved Hide resolved


          fix + nit

337a54f

abi87 commented

View reviewed changes

vms/platformvm/txs/executor/staker_tx_verification.go Show resolved Hide resolved


          another fix

133a58d

abi87 marked this pull request as ready for review

August 22, 2023 20:41

abi87 requested review from danlaine and StephenButtolph as code owners

August 22, 2023 20:41

abi87 commented

View reviewed changes

vms/platformvm/txs/executor/proposal_tx_executor.go Show resolved Hide resolved

abi87 commented

View reviewed changes

vms/platformvm/txs/executor/proposal_tx_executor.go Outdated Show resolved Hide resolved

abi87 commented

View reviewed changes

vms/platformvm/txs/executor/proposal_tx_executor.go Outdated Show resolved Hide resolved

abi87 commented

View reviewed changes

vms/platformvm/txs/executor/proposal_tx_executor.go Outdated Show resolved Hide resolved


          Merge branch 'dev' into reward_tx_refactoring

49d1af7

abi87 requested a review from dhrubabasu

August 22, 2023 21:02

abi87 linked an issue

that may be closed by this pull request

Continuous Staking #1426

Closed

abi87 commented

View reviewed changes

vms/platformvm/txs/executor/proposal_tx_executor.go Show resolved Hide resolved

abi87 commented

View reviewed changes

vms/platformvm/txs/executor/proposal_tx_executor.go Show resolved Hide resolved

abi87 commented

View reviewed changes

vms/platformvm/txs/executor/proposal_tx_executor.go Show resolved Hide resolved

abi87 commented

View reviewed changes

vms/platformvm/txs/executor/proposal_tx_executor.go Show resolved Hide resolved

abi87 commented

View reviewed changes

vms/platformvm/blocks/executor/proposal_block_test.go Show resolved Hide resolved

abi87 added 5 commits

August 22, 2023 23:27


          Merge branch 'dev' into reward_tx_refactoring

a26b0a1

nit

40cfa75


          Merge branch 'dev' into reward_tx_refactoring

0366a0e


          Merge branch 'dev' into reward_tx_refactoring

96f8992


          Merge branch 'dev' into reward_tx_refactoring

ceyonur reviewed

View reviewed changes

vms/platformvm/txs/executor/proposal_tx_executor.go Outdated Show resolved Hide resolved

vms/platformvm/txs/executor/proposal_tx_executor.go Outdated Show resolved Hide resolved

vms/platformvm/txs/executor/proposal_tx_executor.go Outdated Show resolved Hide resolved

vms/platformvm/txs/executor/proposal_tx_executor.go Outdated Show resolved Hide resolved

abi87 added 2 commits

August 29, 2023 09:23


          Merge branch 'dev' into reward_tx_refactoring

d1697c1


          Merge branch 'dev' into reward_tx_refactoring

ca776e3


          exported SplitByShare

50b8bdf

StephenButtolph reviewed

View reviewed changes

vms/platformvm/txs/executor/proposal_tx_executor.go Outdated Show resolved Hide resolved

vms/platformvm/txs/executor/proposal_tx_executor.go Outdated Show resolved Hide resolved


          moved Split to reward package

9c09354

abi87 commented

View reviewed changes

vms/platformvm/reward/calculator.go Show resolved Hide resolved


          nits

d6c9e23

abi87 requested a review from StephenButtolph

September 8, 2023 17:42

abi87 added 5 commits

September 8, 2023 22:17


          Merge branch 'dev' into reward_tx_refactoring


          Merge branch 'dev' into reward_tx_refactoring

599afa6


          Merge branch 'dev' into reward_tx_refactoring

1f7f4be


          Merge branch 'dev' into reward_tx_refactoring

5460cbd


          Merge branch 'dev' into reward_tx_refactoring

d618dcf

StephenButtolph reviewed

View reviewed changes

vms/platformvm/reward/calculator.go Outdated Show resolved Hide resolved

vms/platformvm/reward/calculator.go Show resolved Hide resolved

vms/platformvm/txs/executor/proposal_tx_executor.go Outdated Show resolved Hide resolved

vms/platformvm/txs/executor/proposal_tx_executor.go Outdated Show resolved Hide resolved

vms/platformvm/txs/executor/proposal_tx_executor.go Outdated Show resolved Hide resolved

dhrubabasu reviewed

View reviewed changes

vms/platformvm/txs/executor/proposal_tx_executor.go Outdated Show resolved Hide resolved

abi87 added 2 commits

September 18, 2023 12:01


          Merge branch 'dev' into reward_tx_refactoring

8e05def


          nits

8c2814f

abi87 requested review from dhrubabasu and StephenButtolph

September 18, 2023 10:59

abi87 and others added 4 commits

September 18, 2023 17:12


          fixed comment

1848bb1


          Add tests

e6e5d35


          merged

b09c989


          nits

4fc4710

dhrubabasu reviewed

View reviewed changes

vms/platformvm/reward/calculator.go Outdated Show resolved Hide resolved

StephenButtolph added 2 commits

September 19, 2023 18:09


          cleanup

1f396e1


          cleanup

StephenButtolph approved these changes

View reviewed changes

dhrubabasu approved these changes

View reviewed changes

StephenButtolph added this to the v1.10.11 milestone

StephenButtolph merged commit 56816d7 into dev

StephenButtolph deleted the reward_tx_refactoring branch

September 19, 2023 22:44

dhrubabasu mentioned this pull request

use IsCortinaActivated helper #2048

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

continuous staking