Add metric for the number of elements in a cache #1782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Aug 1, 2023
Comment on lines
+99
to
+101
| if c.elements == nil { | ||
| return 0 | ||
| } |
There was a problem hiding this comment.
Note: if resize() hasn't been called yet - c.elements may be nil
| @@ -110,6 +117,10 @@ func (c *sizedLRU[K, V]) flush() { | |||
| c.currentSize = 0 | |||
| } | |||
|
|
|||
| func (c *sizedLRU[_, _]) len() int { | |||
| return c.elements.Len() | |||
There was a problem hiding this comment.
Do we need the nil check here too?
There was a problem hiding this comment.
no - elements is initialized in NewSizedLRU here
patrick-ogrady
approved these changes
Aug 1, 2023
StephenButtolph
added
the
monitoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
As we convert some of our caches to be size based, the length of the cache is a useful metric.
How this works
Adds
Lento the cache interface and tracks it in themetercacherHow this was tested
CI