[x/sync] Update target locking #1763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-ogrady
changed the title
StephenButtolph
approved these changes
Jul 26, 2023
StephenButtolph
requested review from
danlaine,
darioush and
dboehm-avalabs
as code owners
StephenButtolph
approved these changes
Jul 26, 2023
StephenButtolph
changed the title
patrick-ogrady
commented
Jul 26, 2023
| zap.Binary("start", work.start), | ||
| zap.Binary("end", largestHandledKey), | ||
| zap.Stringer("rootID", rootID), | ||
| zap.Bool("stale", stale), |
There was a problem hiding this comment.
Will be a super useful new log IMO (when I'm hammering this)
darioush
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative: #1762
Why this should be merged
Might resolve: #1760
How this works
We ensure that the sync target cannot be updated while we are determining whether to re-add completed
workItemsto the queue or mark as processed.How this was tested
HyperSDK: ava-labs/hypersdk#278