Skip to content

Add DefaultExecutionConfig var to platformvm #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 24, 2023

Conversation

dhrubabasu
Copy link
Contributor

Why this should be merged

DRYs out the execution config.

How this works

pretty straight forward

How this was tested

CI

@dhrubabasu dhrubabasu added the cleanup Code quality improvement label Jul 22, 2023
@dhrubabasu dhrubabasu added this to the v1.10.6 milestone Jul 22, 2023
@dhrubabasu dhrubabasu self-assigned this Jul 22, 2023
Copy link
Contributor

@StephenButtolph StephenButtolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to be consistent across equality checks... Could go the other way and change the & -> * if we wanted.

@StephenButtolph StephenButtolph merged commit df5cd1f into dev Jul 24, 2023
@StephenButtolph StephenButtolph deleted the execution-config-cleanup branch July 24, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants