fix sync panic #1736
Merged
fix sync panic #1736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dboehm-avalabs
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Could also add a check for the end if you wanted. It isn't strictly needed, but when mid == end then you have [start, end and [end, end] which is kind of pointless. Of course the check to see if mid == end might be more expensive than it is worth so ::shrug::
darioush
approved these changes
Jul 19, 2023
added |
Closed
StephenButtolph
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes a panic.
How this works
See comment in code.
How this was tested
Running merkledb-tester while depending on the new code never panics.