merkledb / sync -- remove TODOs
#1718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
commented
Jul 14, 2023
| @@ -566,7 +566,6 @@ func (db *merkleDB) GetChangeProof( | |||
| return i.Compare(j) < 0 | |||
| }) | |||
|
|
|||
| // TODO: sync.pool these buffers | |||
There was a problem hiding this comment.
I don't think this would be worth the added cognitive load
danlaine
commented
Jul 14, 2023
Comment on lines
-193
to
-196
| // TODO danlaine: We won't release [m.workLock] until | ||
| // we've started a goroutine for each available work item. | ||
| // We can't apply proofs we receive until we release [m.workLock]. | ||
| // Is this OK? Is it possible we end up with too many goroutines? |
There was a problem hiding this comment.
This was fixed a while back by the above case:
case m.processingWorkItems >= m.config.SimultaneousWorkLimit:
// We're already processing the maximum number of work items.
// Wait until one of them finishes.
m.unprocessedWorkCond.Wait()
danlaine
commented
Jul 14, 2023
StephenButtolph
approved these changes
Jul 17, 2023
I'm down to remove it |
darioush
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
I think these TODOs are TODONT's
How this works
Remove comments
How this was tested
N/A