Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
There's a bug in #1534. #1586 is built atop 1534.
The iterator of
linkedhashmap
, used by the node cache, says:but in
onEvictCache
'sFlush
method, called onClose
, we do exactly this. Namely, when we callc.onEviction
, we callremoveOldest
on the cache which modifies thelinkedHashmap
.Will make a subsequent PR to revert #1534. #1586 was built atop #1534.
How this works
Revert #1534 and #1586
How this was tested
N/A