Skip to content

Revert PRs 1534 and 1586 #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Revert PRs 1534 and 1586 #1588

wants to merge 1 commit into from

Conversation

danlaine
Copy link

@danlaine danlaine commented Jun 6, 2023

Why this should be merged

There's a bug in #1534. #1586 is built atop 1534.

The iterator of linkedhashmap, used by the node cache, says:

// Assumes the underlying LinkedHashmap is not modified while
// the iterator is in use, except to delete elements that
// have already been iterated over.

but in onEvictCache's Flush method, called on Close, we do exactly this. Namely, when we call c.onEviction, we call removeOldest on the cache which modifies the linkedHashmap.

Will make a subsequent PR to revert #1534. #1586 was built atop #1534.

How this works

Revert #1534 and #1586

How this was tested

N/A

@danlaine danlaine self-assigned this Jun 6, 2023
@danlaine danlaine marked this pull request as draft June 6, 2023 16:13
@danlaine
Copy link
Author

danlaine commented Jun 6, 2023

converted to a draft while we consider other fixes

@danlaine
Copy link
Author

danlaine commented Jun 6, 2023

Closing in favor of #1589

@danlaine danlaine closed this Jun 6, 2023
@danlaine danlaine deleted the revert-prs-1534-and-1586 branch June 6, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant