Remove check for impossible condition in x/sync
#1348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
reviewed
Apr 14, 2023
| @@ -186,11 +186,6 @@ func (c *networkClient) RequestAny( | |||
| // If the limit on active requests is reached, this function blocks until | |||
| // a slot becomes available. | |||
| func (c *networkClient) Request(ctx context.Context, nodeID ids.NodeID, request []byte) ([]byte, error) { | |||
| // TODO danlaine: is it possible for this condition to occur? | |||
| if nodeID == ids.EmptyNodeID { | |||
| return nil, fmt.Errorf("cannot send request to empty nodeID, nodeID=%s, requestLen=%d", nodeID, len(request)) | |||
There was a problem hiding this comment.
This seems like a useful check to leave on the exported method, I think.
Even if all current uses are correct it might catch errors in future development.
Not very strongly opinionated, happy to defer to @dboehm-avalabs
dboehm-avalabs
approved these changes
Apr 17, 2023
darioush
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The node ID should never be empty
How this works
Self explanatory
How this was tested
Existing UT