refactor: use maps.Copy for cleaner map handling (#4119)

Signed-off-by: jishudashu <979260390@qq.com>

Author: jishudashu

tests/antithesis/compose.go

@@ -6,6 +6,7 @@ package antithesis
 import (
 	"errors"
 	"fmt"
+	"maps"
 	"os"
 	"path/filepath"
 
@@ -179,9 +180,7 @@ func newComposeProject(network *tmpnet.Network, nodeImageName string, workloadIm
 		}
 
 		// Apply configuration appropriate to a test network
-		for k, v := range tmpnet.DefaultTmpnetFlags() {
-			env[k] = v
-		}
+		maps.Copy(env, tmpnet.DefaultTmpnetFlags())
 
 		serviceName := getServiceName(i)
 

tests/fixture/tmpnet/monitor_processes.go

@@ -9,6 +9,7 @@ import (
 	"fmt"
 	"io"
 	"io/fs"
+	"maps"
 	"net/http"
 	"os"
 	"os/exec"
@@ -316,9 +317,7 @@ func WritePrometheusSDConfig(name string, sdConfig SDConfig, withGitHubLabels bo
 }
 
 func applyGitHubLabels(sdConfig SDConfig) SDConfig {
-	for label, value := range GetGitHubLabels() {
-		sdConfig.Labels[label] = value
-	}
+	maps.Copy(sdConfig.Labels, GetGitHubLabels())
 	return sdConfig
 }
 

tests/fixture/tmpnet/network.go

@@ -11,6 +11,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
+	"maps"
 	"net/netip"
 	"os"
 	"os/exec"
@@ -926,9 +927,7 @@ func (n *Network) GetMonitoringLabels() map[string]string {
 		"is_ephemeral_node": "false",
 		"network_owner":     n.Owner,
 	}
-	for label, value := range GetGitHubLabels() {
-		labels[label] = value
-	}
+	maps.Copy(labels, GetGitHubLabels())
 	return labels
 }
 

tests/reexecute/c/vm_reexecute_test.go

@@ -9,6 +9,7 @@ import (
 	"errors"
 	"flag"
 	"fmt"
+	"maps"
 	"os"
 	"path/filepath"
 	"strings"
@@ -91,9 +92,7 @@ func TestMain(m *testing.M) {
 		fmt.Fprintf(os.Stderr, "failed to parse labels: %v\n", err)
 		os.Exit(1)
 	}
-	for customLabel, customValue := range customLabels {
-		labels[customLabel] = customValue
-	}
+	maps.Copy(labels, customLabels)
 
 	m.Run()
 }

vms/platformvm/client.go

@@ -5,6 +5,7 @@ package platformvm
 
 import (
 	"context"
+	"maps"
 	"time"
 
 	"github.com/ava-labs/avalanchego/api"
@@ -654,11 +655,7 @@ func GetOwners(
 	}
 
 	owners := make(map[ids.ID]fx.Owner, len(subnetOwners)+len(deactivationOwners))
-	for id, owner := range subnetOwners {
-		owners[id] = owner
-	}
-	for id, owner := range deactivationOwners {
-		owners[id] = owner
-	}
+	maps.Copy(owners, subnetOwners)
+	maps.Copy(owners, deactivationOwners)
 	return owners, nil
 }