Skip to content

Commit d2454b7

Browse files
authored
[ci] Fix windows build job by reverting to use build script (#3921)
1 parent 2bf5dc4 commit d2454b7

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

.github/workflows/build-win-release.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,12 @@ jobs:
6060

6161
# Runs a single command using the runners shell
6262
- name: Build the avalanchego binary
63-
run: ./scripts/run_task.sh build
63+
# This is the only permitted instance of using a script other
64+
# than run_task.sh in a github workflow. The build script is
65+
# known to work on windows but invoking `task build` fails and
66+
# without a windows host to test on it's not worth
67+
# troubleshooting.
68+
run: ./scripts/build.sh
6469
shell: bash
6570

6671
- name: Create zip

scripts/actionlint.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ for file in .github/workflows/*.{yml,yaml}; do
1010
# Skip if no matches found (in case one of the extensions doesn't exist)
1111
[[ -f "$file" ]] || continue
1212

13+
# Skip build-win-release due to not having an easy way to test go-task on windows
14+
[[ "$file" == *build-win-release.yml ]] && continue
15+
1316
# Search for scripts/* except for scripts/run_task.sh
1417
MATCHES=$(grep -H -n -P "scripts/(?!run_task\.sh)" "$file" || true)
1518
if [[ -n "${MATCHES}" ]]; then

0 commit comments

Comments
 (0)