[snow/networking] Enforce PreferredIDAtHeight in Chits messages (#2827)

dhrubabasu · web-flow · commit a593cc4147b3 · 2024-03-07T22:45:11.000Z
diff --git a/snow/networking/handler/handler.go b/snow/networking/handler/handler.go
@@ -716,9 +716,7 @@ func (h *handler) handleSyncMsg(ctx context.Context, msg Message) error {
 				zap.String("field", "PreferredIDAtHeight"),
 				zap.Error(err),
 			)
-			// TODO: Require this field to be populated correctly after v1.11.x
-			// is activated.
-			preferredIDAtHeight = preferredID
+			return engine.QueryFailed(ctx, nodeID, msg.RequestId)
 		}
 
 		acceptedID, err := ids.ToID(msg.AcceptedId)

Original file line number	Diff line number	Diff line change
`@@ -716,9 +716,7 @@ func (h *handler) handleSyncMsg(ctx context.Context, msg Message) error {`
`716`	`716`	`zap.String("field", "PreferredIDAtHeight"),`
`717`	`717`	`zap.Error(err),`
`718`	`718`	`)`
`719`		`- // TODO: Require this field to be populated correctly after v1.11.x`
`720`		`- // is activated.`
`721`		`- preferredIDAtHeight = preferredID`
	`719`	`+ return engine.QueryFailed(ctx, nodeID, msg.RequestId)`
`722`	`720`	`}`
`723`	`721`
`724`	`722`	`acceptedID, err := ids.ToID(msg.AcceptedId)`