Skip to content

Commit 9374b56

Browse files
Fix --http-host flag to support IPv6 (#1620)
1 parent cc69f03 commit 9374b56

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

api/server/server.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ type server struct {
9090
factory logging.Factory
9191
// Listens for HTTP traffic on this address
9292
listenHost string
93-
listenPort uint16
93+
listenPort string
9494

9595
shutdownTimeout time.Duration
9696

@@ -154,7 +154,7 @@ func New(
154154
log: log,
155155
factory: factory,
156156
listenHost: host,
157-
listenPort: port,
157+
listenPort: fmt.Sprintf("%d", port),
158158
shutdownTimeout: shutdownTimeout,
159159
tracingEnabled: tracingEnabled,
160160
tracer: tracer,
@@ -171,7 +171,7 @@ func New(
171171
}
172172

173173
func (s *server) Dispatch() error {
174-
listenAddress := fmt.Sprintf("%s:%d", s.listenHost, s.listenPort)
174+
listenAddress := net.JoinHostPort(s.listenHost, s.listenPort)
175175
listener, err := net.Listen("tcp", listenAddress)
176176
if err != nil {
177177
return err
@@ -193,7 +193,7 @@ func (s *server) Dispatch() error {
193193
}
194194

195195
func (s *server) DispatchTLS(certBytes, keyBytes []byte) error {
196-
listenAddress := fmt.Sprintf("%s:%d", s.listenHost, s.listenPort)
196+
listenAddress := net.JoinHostPort(s.listenHost, s.listenPort)
197197
cert, err := tls.X509KeyPair(certBytes, keyBytes)
198198
if err != nil {
199199
return err

0 commit comments

Comments
 (0)