Skip to content

Commit 7f3c7a9

Browse files
committed
fixup: Address review feedback #2
1 parent bee7a9b commit 7f3c7a9

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

tests/e2e/e2e.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ const (
3232

3333
// Interval appropriate for network operations that should be
3434
// retried periodically but not too often.
35-
DefaultPollingInterval = 1 * time.Millisecond
35+
DefaultPollingInterval = 500 * time.Millisecond
3636
)
3737

3838
// Env is used to access shared test fixture. Intended to be

tests/fixture/test_data_server_test.go

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import (
88

99
"github.com/stretchr/testify/require"
1010

11+
"github.com/ava-labs/avalanchego/ids"
1112
"github.com/ava-labs/avalanchego/utils/crypto/secp256k1"
1213
)
1314

@@ -32,21 +33,21 @@ func TestAllocateFundedKeys(t *testing.T) {
3233
testCases := []struct {
3334
name string
3435
count int
35-
expectedAddresses []string
36+
expectedAddresses []ids.ShortID
3637
}{{
3738
name: "single key",
3839
count: 1,
39-
expectedAddresses: []string{
40-
keys[4].Address().String(),
40+
expectedAddresses: []ids.ShortID{
41+
keys[4].Address(),
4142
},
4243
}, {
4344
name: "multiple keys",
4445
count: 4,
45-
expectedAddresses: []string{
46-
keys[0].Address().String(),
47-
keys[1].Address().String(),
48-
keys[2].Address().String(),
49-
keys[3].Address().String(),
46+
expectedAddresses: []ids.ShortID{
47+
keys[0].Address(),
48+
keys[1].Address(),
49+
keys[2].Address(),
50+
keys[3].Address(),
5051
},
5152
}, {
5253
name: "insufficient keys available",
@@ -59,9 +60,9 @@ func TestAllocateFundedKeys(t *testing.T) {
5960
require.ErrorIs(err, errRequestedKeyCountExceedsAvailable)
6061
} else {
6162
require.NoError(err)
62-
addresses := []string{}
63+
addresses := []ids.ShortID{}
6364
for _, key := range keys {
64-
addresses = append(addresses, key.Address().String())
65+
addresses = append(addresses, key.Address())
6566
}
6667
require.Equal(tc.expectedAddresses, addresses)
6768
}

0 commit comments

Comments
 (0)