Custom vm path for devnet #2948
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukantoraymond
requested review from
artemanosov,
cwend-ava,
jasonatran and
meaghanfitzgerald
There was a problem hiding this comment.
This is a really nice add on, but we should try to separate the local binary from the cloud binary as they are not necessarily going to be the same and we probably need both.
Some extra comments:
- the binary specified by vmPath should be already available at the ~/.avalanche-cli/vms/, so not need to persist the original path in the sidecar
- persisting a path given by the user in sidecar exposes to later fail, if the user removes this file, it is not managed by CLI so should be copied into ~/.avalanche-cli, probably
- this brakes local neworks tests for the vm, because you are passing in a binary for aws, that is stored and then used in local networks
| return err | ||
| } | ||
| subnetVMBinaryPath := fmt.Sprintf(constants.CloudNodeSubnetEvmBinaryPath, vmID) | ||
| ux.Logger.Info("Building Custom VM for %s to %s", host.NodeID, subnetVMBinaryPath) |
There was a problem hiding this comment.
it is not strictly building
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies custom vm binary specified in custom vm path flag for
node devnet wizcommand to remote hosts