From 0f0df928d484237d6fb57f4d8355a078d83b0f45 Mon Sep 17 00:00:00 2001
From: Evan Rusackas <evan@preset.io>
Date: Fri, 18 Sep 2020 12:23:48 -0700
Subject: [PATCH] Ignore '/docs' on some GH actions, give docs its own action
 (#10949)

* ignore docs on several actions, give docs its own action

* Random doc change to see if the new action runs.

* umm... not paths-ignore, paths!

* eof fix

* enabling typescript checking on docs
---
 .github/workflows/superset-docs.yml     | 30 +++++++++++++++++++++++++
 .github/workflows/superset-e2e.yml      |  8 ++++++-
 .github/workflows/superset-frontend.yml | 23 ++++++-------------
 .github/workflows/superset-python.yml   |  8 ++++++-
 .github/workflows/test-hive.yml         |  8 ++++++-
 .github/workflows/test-presto.yml       |  8 ++++++-
 docs/src/pages/404.jsx                  |  2 +-
 7 files changed, 66 insertions(+), 21 deletions(-)
 create mode 100644 .github/workflows/superset-docs.yml

diff --git a/.github/workflows/superset-docs.yml b/.github/workflows/superset-docs.yml
new file mode 100644
index 0000000000000..95039732a1c49
--- /dev/null
+++ b/.github/workflows/superset-docs.yml
@@ -0,0 +1,30 @@
+name: Docs
+
+on:
+  push:
+    paths:
+      - 'docs/**'
+  pull_request:
+    paths:
+      - 'docs/**'
+
+jobs:
+  docs:
+    name: build
+    runs-on: ubuntu-18.04
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v2
+    - name: Install dependencies
+    - name: npm install
+      working-directory: ./docs
+      run: |
+        npm install
+    - name: lint
+      working-directory: ./docs
+      run: |
+        npm run lint
+    - name: gatsby build
+      working-directory: ./docs
+      run: |
+        npm run build
diff --git a/.github/workflows/superset-e2e.yml b/.github/workflows/superset-e2e.yml
index dfa691058ac65..f634e1544cc25 100644
--- a/.github/workflows/superset-e2e.yml
+++ b/.github/workflows/superset-e2e.yml
@@ -1,6 +1,12 @@
 name: E2E
 
-on: [push, pull_request]
+on:
+  push:
+    paths-ignore:
+      - 'docs/**'
+  pull_request:
+    paths-ignore:
+      - 'docs/**'
 
 jobs:
   Cypress:
diff --git a/.github/workflows/superset-frontend.yml b/.github/workflows/superset-frontend.yml
index 86d0e533cd84a..0f0b5db48548b 100644
--- a/.github/workflows/superset-frontend.yml
+++ b/.github/workflows/superset-frontend.yml
@@ -1,6 +1,12 @@
 name: Frontend
 
-on: [push, pull_request]
+on:
+  push:
+    paths-ignore:
+      - 'docs/**'
+  pull_request:
+    paths-ignore:
+      - 'docs/**'
 
 jobs:
   build:
@@ -25,18 +31,3 @@ jobs:
       working-directory: ./superset-frontend
       run: |
         bash <(curl -s https://codecov.io/bash) -cF javascript
-
-  docs:
-    name: build
-    runs-on: ubuntu-18.04
-    steps:
-    - name: Checkout code
-      uses: actions/checkout@v2
-    - name: Install dependencies
-      working-directory: ./superset-frontend
-      run: |
-        npm install
-    - name: gatsby build
-      working-directory: ./superset-frontend
-      run: |
-        npm run build
diff --git a/.github/workflows/superset-python.yml b/.github/workflows/superset-python.yml
index 6bfe3772185a7..5da41d9f5c93b 100644
--- a/.github/workflows/superset-python.yml
+++ b/.github/workflows/superset-python.yml
@@ -1,7 +1,13 @@
 # Python unit tests
 name: Python
 
-on: [push, pull_request]
+on:
+  push:
+    paths-ignore:
+      - 'docs/**'
+  pull_request:
+    paths-ignore:
+      - 'docs/**'
 
 jobs:
   lint:
diff --git a/.github/workflows/test-hive.yml b/.github/workflows/test-hive.yml
index 2571f4a2f85ee..b372be4519f56 100644
--- a/.github/workflows/test-hive.yml
+++ b/.github/workflows/test-hive.yml
@@ -1,6 +1,12 @@
 name: Hive
 
-on: [push, pull_request]
+on:
+  push:
+    paths-ignore:
+      - 'docs/**'
+  pull_request:
+    paths-ignore:
+      - 'docs/**'
 
 jobs:
   test-postgres-hive:
diff --git a/.github/workflows/test-presto.yml b/.github/workflows/test-presto.yml
index 14ac0a8f5eafa..360026b056cfc 100644
--- a/.github/workflows/test-presto.yml
+++ b/.github/workflows/test-presto.yml
@@ -1,6 +1,12 @@
 name: Presto
 
-on: [push, pull_request]
+on:
+  push:
+    paths-ignore:
+      - 'docs/**'
+  pull_request:
+    paths-ignore:
+      - 'docs/**'
 
 jobs:
   test-postgres-presto:
diff --git a/docs/src/pages/404.jsx b/docs/src/pages/404.jsx
index 325d51aa61be2..12b044ad47c15 100644
--- a/docs/src/pages/404.jsx
+++ b/docs/src/pages/404.jsx
@@ -25,7 +25,7 @@ const NotFoundPage = () => (
   <Layout>
     <SEO title="404: Not found" />
     <h1>NOT FOUND</h1>
-    <p>You just hit a route that does not exist... the sadness.</p>
+    <p>Sorry, you've requested a page that does not exist.</p>
   </Layout>
 );