-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Learning-Based Accel/Brake Map Calibrator #231
Open
CristianGariboldi
wants to merge
7
commits into
autowarefoundation:main
Choose a base branch
from
CristianGariboldi:learning_based_calibrator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add Learning-Based Accel/Brake Map Calibrator #231
CristianGariboldi
wants to merge
7
commits into
autowarefoundation:main
from
CristianGariboldi:learning_based_calibrator
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
…log (autowarefoundation#228) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: CristianGariboldi <gariboldicristian@gmail.com>
Signed-off-by: CristianGariboldi <gariboldicristian@gmail.com>
Signed-off-by: CristianGariboldi <gariboldicristian@gmail.com>
bc8a353
to
5f9af35
Compare
Signed-off-by: CristianGariboldi <gariboldicristian@gmail.com>
Signed-off-by: CristianGariboldi <gariboldicristian@gmail.com>
389a945
to
a171e56
Compare
@xmfcx Hi, just for your information, I opened the previous pull request in Autoware Tools, as you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the PR regarding the learning-based vehicle calibration for longitudinal dynamics already discussed and presented in the discussion thread and in the Planning and Control meeting.
Tests performed
This calibrator has been tested in simulation and real vehicles. We've been using the calibrator for a different range of vehicles in Pix Moving with high accuracy.
Additional materials here:
Pix_Longitudinal_Calibration.pdf
Calibration.pptx
Effects on system behavior
This new calibrator improves the previous one in different aspects:
real data are interpolated with a neural network, which is able to provide a very accurate and smooth map, and can capture the non-linearities of the system;
the whole calibration process is very user-friendly, fast and efficient;
you don't need a huge amount of data for training the neural network, making the data collection process faster;
the learning-based approach can be easily adapted to different kind of scenarios, and not solely on the longitudinal dynamic. In my previous pull request for example, I also included the calibration for steering/parking scenarios, just by adding 1 input to the network;
It can be used with a diverse range of vehicles, with different dynamics, kinematics, engines and transmission systems;
It has been tested in simulation and with real vehicles. We now use it for calibrating our vehicles in Pix Moving.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.