-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use THROTTLE to output log #969
Conversation
Codecov Report
@@ Coverage Diff @@
## main #969 +/- ##
=====================================
Coverage 9.67% 9.67%
=====================================
Files 947 947
Lines 63373 63373
Branches 10965 10965
=====================================
Hits 6132 6132
Misses 52271 52271
Partials 4970 4970
Continue to review full report at Codecov.
|
@h-ohta @yukkysaito |
@taikitanaka3 Could you tell me more details of your question? |
It is difficult it should be a warning or an error. |
@h-ohta |
@taikitanaka3 Thank you for your information. I understand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agreed to use throttle for no collision case with stop line when ego path is end before stop line.
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
* release v0.4.0 * Add spline interpolation library (autowarefoundation#705) * Feature/intersection use spline interpolation library (autowarefoundation#710) * Use spline_interpolation module * Remove debug messages * Fix/spline interpolation in intersection module (autowarefoundation#726) * Remove duplicating sample points * Change isValidInput * Apply clang-format * Fix convergence check in PCG * update osqp interface (autowarefoundation#730) * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add sample ros2 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * remove ROS1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit 7127cf7. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Port osqp-interface to ros2 (autowarefoundation#45) It doesn't use any ros functionality so the source code is unchanged, only `package.xml` and `CMakeLists.txt` needed to be modified. But osqp is added through a vendor package created at https://github.com/tier4/osqp_vendor To test this locally, eigen needs to be installed in the environment with sudo apt install libeigen3-dev * Port spline interpolation to ros2. (autowarefoundation#65) * Fix osqp_interface dependencies (autowarefoundation#66) * [osqp_interface] fix eigen3 dependencies fixes autowarefoundation#63 * Fix link order in consumers of osqp_interface * Update logger name for SOR class (autowarefoundation#87) Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org> * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * ROS2 Linting: osqp_interface (autowarefoundation#202) * Add linters * Fix clang-tidy missing header error * ROS2 Linting: spline_interpolation (autowarefoundation#203) * Add linters and fix indentation in package.xml * Address PR comments: - Convert indents to spaces * Use two spaces for indent Co-authored-by: Esteve Fernandez <esteve@apache.org> * Fix out-of-range bug of spline_interpolation (autowarefoundation#917) (autowarefoundation#273) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Ros2 v0.8.0 osqp interface (autowarefoundation#271) * restore file name for v0.8.0 update Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix typos in common modules (autowarefoundation#914) * fix typos in common modules * minor fix (lowercasing) * revert changes in PathPoint.msg * Fix/osqp interface api error (autowarefoundation#969) * [osqp_interface] fix update setting api Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [osqp_interface] fix format Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Revert "restore file name for v0.8.0 update" This reverts commit b767c308d492c6f754f9aa45ab9521f209ad9c9c. Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Ros2 v0.8.0 ekf localizer (autowarefoundation#270) * restore file name for v0.8.0 update Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix typos in localization (autowarefoundation#890) * move kalman filter to lib package (autowarefoundation#1141) * move kalman filter to lib package * add kalman_filter dir * Revert "restore file name for v0.8.0 update" This reverts commit 485111da0aba91eeddda77e1e3b6b3f517373163. Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> * Feature/ekf tracker (autowarefoundation#1158) (autowarefoundation#381) * Feature/ekf tracker (autowarefoundation#1158) * change to ekf tracker * visualize covariance * cosmetic change * cosmetic change * change param * add multi model ekf tracker (autowarefoundation#1165) * add multi model ekf tracker * cosmetic change * cosmetic change * add iou filter * change correct license * change correct license * cosmetic change * bug fix * cosmetic change * check clockwise * change param * bug fix * cosmetic change * add comment * add enum * cosmetic change * cosmetic change * apply format * apply format * fix config name Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * [multi_object_tracker] apply ament_uncrustify Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * [multi_object_tracker] fix lint errors Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * fix include brackets Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Fix typo in common module (autowarefoundation#433) * Unify Apache-2.0 license name (autowarefoundation#1242) * Make control modules components (autowarefoundation#1262) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Make planning modules components (autowarefoundation#1263) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Porting small fix (autowarefoundation#1288) * Delete unused code (autowarefoundation#1183) * Fix control topic name of closest_velocity_checker.py (autowarefoundation#1174) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add comments for livox tag (autowarefoundation#1188) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Clear return value (autowarefoundation#1193) * Change tracker model of unknown object (autowarefoundation#1204) * treat polygon points as relative (autowarefoundation#1205) Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * hotfix: reference velocity in consideration of vehicle gear (autowarefoundation#1213) * fix reference velocity for vehicle gear * add initialization * revert * add comment * change max area param (autowarefoundation#1218) * Fix an identical code for different branches (autowarefoundation#1230) * Update livox_tag_filter.launch.xml * Fixup Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: shin <8327162+0x126@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix osqp interface double free problem (autowarefoundation#1327) * Use smart pointers for members * Add test code * Fix typo * Fix test code * Change variable name * Fix for lint test * Fix include * Fix header and CMakeLists.txt Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * add new updater function to osqp_interface (autowarefoundation#1433) (autowarefoundation#1483) * add new updater function * modify spell Co-authored-by: purewater0901 <43805014+purewater0901@users.noreply.github.com> * Add pre-commit (autowarefoundation#1560) * add pre-commit * add pre-commit-config * add additional settings for private repository * use default pre-commit-config * update pre-commit setting * Ignore whitespace for line breaks in markdown * Update .github/workflows/pre-commit.yml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * exclude svg * remove pretty-format-json * add double-quote-string-fixer * consider COLCON_IGNORE file when seaching modified package * format file * pre-commit fixes * Update pre-commit.yml * Update .pre-commit-config.yaml Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: pre-commit <pre-commit@example.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * Fix bugprone-fold-init-type in spline_interpolation (autowarefoundation#1816) * Fix bugprone-fold-init-type * Fix modernize-use-override * Fix cppcoreguidelines-pro-type-member-init * Fix modernize-loop-convert * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * remove spline_interpolation, and create interpolation package that ha… (autowarefoundation#2114) * remove spline_interpolation and add interpolation package * fix bugs and add simple test * modify application for interpolation package * add some tests and fix ci test * add some tests * add -Werror * move functions to anonymous * fix reviews * fix typo * fix review and lint * add tests * resolve TODOs * add README.md * Update common/math/interpolation/test/src/test_interpolation_utils.cpp Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update common/math/interpolation/test/src/test_interpolation_utils.cpp Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update common/math/interpolation/test/src/test_interpolation_utils.cpp Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * fix README.md * dealt with reviews * update README.md * update README.md * Update common/math/interpolation/README.md * fix some bugs * fix typo * update README.md * Update common/math/interpolation/README.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * fix test * Update common/math/interpolation/README.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * fix cdots * fix README.md * Update common/math/interpolation/README.md Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * Feature/lpf in common ros2 (autowarefoundation#1628) * add first order lowpass filter (autowarefoundation#1505) * add first order lowpass filter * fix bugs, and add tests * update copyright * apply clang-format * add another constructor * add another reset member function * update * add test * update test * update test * rename lowpass filter to signal processing * Porting lpf1d to ros2 Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> * [osqp interface] size check invalid argument error ros2 (autowarefoundation#1870) * throw invalid_argument when osqp matrix/vector are invalid * add test for invalid_argumetn * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * remove COLCON_IGNORE (autowarefoundation#506) Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp> * Remove COLCON_IGNORE from interpolation (autowarefoundation#516) * delete COLCON IGNORE in signal processing package(autowarefoundation#537) * Delet colcon ignore (autowarefoundation#534) * Back port .auto control packages (autowarefoundation#571) * Implement Lateral and Longitudinal Control Muxer * [autowarefoundation#570] Porting wf_simulator * [autowarefoundation#1189] Deactivate flaky test in 'trajectory_follower_nodes' * [autowarefoundation#1189] Fix flacky test in 'trajectory_follower_nodes/latlon_muxer' * [autowarefoundation#1057] Add osqp_interface package * [autowarefoundation#1057] Add library code for MPC-based lateral control * [autowarefoundation#1271] Use std::abs instead of abs * [autowarefoundation#1057] Implement Lateral Controller for Cargo ODD * [autowarefoundation#1246] Resolve "Test case names currently use snake_case but should be CamelCase" * [autowarefoundation#1325] Deactivate flaky smoke test in 'trajectory_follower_nodes' * [autowarefoundation#1058] Add library code of longitudinal controller * Fix build error for trajectory follower Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix build error for trajectory follower nodes Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [autowarefoundation#1272] Add AckermannControlCommand support to simple_planning_simulator * [autowarefoundation#1058] Add Longitudinal Controller node * [autowarefoundation#1058] Rename velocity_controller -> longitudinal_controller * [autowarefoundation#1058] Update CMakeLists.txt for the longitudinal_controller_node * [autowarefoundation#1058] Add smoke test python launch file * [autowarefoundation#1058] Use LowPassFilter1d from trajectory_follower * [autowarefoundation#1058] Use autoware_auto_msgs * [autowarefoundation#1058] Changes for .auto (debug msg tmp fix, common func, tf listener) * [autowarefoundation#1058] Remove unused parameters * [autowarefoundation#1058] Fix ros test * [autowarefoundation#1058] Rm default params from declare_parameters + use autoware types * [autowarefoundation#1058] Use default param file to setup NodeOptions in the ros test * [autowarefoundation#1058] Fix docstring * [autowarefoundation#1058] Replace receiving a Twist with a VehicleKinematicState * [autowarefoundation#1058] Change class variables format to m_ prefix * [autowarefoundation#1058] Fix plugin name of LongitudinalController in CMakeLists.txt * [autowarefoundation#1058] Fix copyright dates * [autowarefoundation#1058] Reorder includes * [autowarefoundation#1058] Add some tests (~89% coverage without disabling flaky tests) * [autowarefoundation#1058] Add more tests (90+% coverage without disabling flaky tests) * [autowarefoundation#1058] Use Float32MultiArrayDiagnostic message for debug and slope * [autowarefoundation#1058] Calculate wheel_base value from vehicle parameters * [autowarefoundation#1058] Cleanup redundant logger setting in tests * [autowarefoundation#1058] Set ROS_DOMAIN_ID when running tests to prevent CI failures * [autowarefoundation#1058] Remove TF listener and use published vehicle state instead * [autowarefoundation#1058] Change smoke tests to use autoware_testing * [autowarefoundation#1058] Add plotjuggler cfg for both lateral and longitudinal control * [autowarefoundation#1058] Improve design documents * [autowarefoundation#1058] Disable flaky test * [autowarefoundation#1058] Properly transform vehicle state in longitudinal node * [autowarefoundation#1058] Fix TF buffer of lateral controller * [autowarefoundation#1058] Tuning of lateral controller for LGSVL * [autowarefoundation#1058] Fix formating * [autowarefoundation#1058] Fix /tf_static sub to be transient_local * [autowarefoundation#1058] Fix yaw recalculation of reverse trajs in the lateral controller * modify trajectory_follower for galactic build Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [autowarefoundation#1379] Update trajectory_follower * [autowarefoundation#1379] Update simple_planning_simulator * [autowarefoundation#1379] Update trajectory_follower_nodes * apply trajectory msg modification in control Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * move directory Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remote control/trajectory_follower level dorectpry Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove .iv trajectory follower Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * use .auto trajectory_follower Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove .iv simple_planning_simulator & osqp_interface Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * use .iv simple_planning_simulator & osqp_interface Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add tmp_autoware_auto_dependencies Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * tmporally add autoware_auto_msgs Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * apply .auto message split Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix build depend Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix packages using osqp * fix autoware_auto_geometry * ignore lint of some packages * ignore ament_lint of some packages * ignore lint/pre-commit of trajectory_follower_nodes * disable unit tests of some packages Co-authored-by: Maxime CLEMENT <maxime.clement@tier4.jp> Co-authored-by: Joshua Whitley <josh.whitley@autoware.org> Co-authored-by: Igor Bogoslavskyi <igor.bogoslavskyi@gmail.com> Co-authored-by: MIURA Yasuyuki <kokosabu@gmail.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: tomoya.kimura <tomoya.kimura@tier4.jp> * add readme signal processing (autowarefoundation#587) * add readme signal processing * better fix * add readme in kalman_filter (autowarefoundation#633) * ci(pre-commit): autofix Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com> Co-authored-by: Yunus Emre Çalışkan <yunus.ec@gmail.com> Co-authored-by: Servando <43142004+sgermanserrano@users.noreply.github.com> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com> Co-authored-by: Jilada Eccleston <jilada.eccleston@tier4.jp> Co-authored-by: Esteve Fernandez <esteve@apache.org> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp> Co-authored-by: shin <8327162+0x126@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: purewater0901 <43805014+purewater0901@users.noreply.github.com> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: pre-commit <pre-commit@example.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp> Co-authored-by: Sugatyon <32741405+Sugatyon@users.noreply.github.com> Co-authored-by: Yohei Mishina <66298900+YoheiMishina@users.noreply.github.com> Co-authored-by: Maxime CLEMENT <maxime.clement@tier4.jp> Co-authored-by: Joshua Whitley <josh.whitley@autoware.org> Co-authored-by: Igor Bogoslavskyi <igor.bogoslavskyi@gmail.com> Co-authored-by: MIURA Yasuyuki <kokosabu@gmail.com> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
feat(intersection): timeout static occlusion with traffic light
Description
When a lane has stopline but a path does not intersect with a stopline, the following log continues to output.
An example is the following image.
This PR suppreses its frequency.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.