Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(joy_controller): adding genesis joystick to joy controller #683

Merged
merged 4 commits into from
Apr 12, 2022
Merged

feat(joy_controller): adding genesis joystick to joy controller #683

merged 4 commits into from
Apr 12, 2022

Conversation

brkay54
Copy link
Member

@brkay54 brkay54 commented Apr 12, 2022 •
edited by kenji-miyake
Loading

Description

Closes [#682]

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@brkay54 brkay54 changed the title Add genesis joystick to joy controller feat(joy_controller): adding genesis joystick to joy controller Apr 12, 2022
@brkay54 brkay54 force-pushed the add-genesis-joystick-to-joy-controller branch 3 times, most recently from c7b036b to 48b367a Compare April 12, 2022 10:56
@brkay54
feat(joy_controller): add genesis p65 converter
8ad6a12 
Signed-off-by: Berkay <berkay@leodrive.ai>
@brkay54
feat(joy_controller): fix steering direction
407514d 
Signed-off-by: Berkay <berkay@leodrive.ai>
@brkay54
feat(joy_controller): changed map
88e96e8 
Signed-off-by: Berkay <berkay@leodrive.ai>
@brkay54 brkay54 force-pushed the add-genesis-joystick-to-joy-controller branch from 23dae17 to 88e96e8 Compare April 12, 2022 10:59
@codecov
Copy link

codecov bot commented Apr 12, 2022 •
edited
Loading

Codecov Report

Merging #683 (b0a8503) into main (dc682e6) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
- Coverage   10.59%   10.56%   -0.04%     
==========================================
  Files         734      735       +1     
  Lines       51719    51875     +156     
  Branches     6596     6596              
==========================================
  Hits         5482     5482              
- Misses      41777    41933     +156     
  Partials     4460     4460
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.59% <0.00%> (ø) Carriedforward from dc682e6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...joy_controller/joy_converter/p65_joy_converter.hpp 0.00% <0.00%> (ø)
...troller/src/joy_controller/joy_controller_node.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f08233a...b0a8503. Read the comment docs.

@brkay54 brkay54 self-assigned this Apr 12, 2022
kenji-miyake
kenji-miyake approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test this because I don't have the device, but the code looks good to me!

@kenji-miyake
Copy link
Contributor

@xmfcx cc @mitsudome-r @yukkysaito
Should I give write access of autoware.universe to the autoware-developers-leodrive team and let them merge PRs?
Or will we add some Leo Drive members to the autoware-maintainers team?
Or should TIER IV members and maintainers merge PRs?

@xmfcx
Copy link
Contributor

xmfcx commented Apr 12, 2022

@xmfcx cc @mitsudome-r @yukkysaito Should I give write access of autoware.universe to the autoware-developers-leodrive team and let them merge PRs? Or will we add some Leo Drive members to the autoware-maintainers team? Or should TIER IV members and maintainers merge PRs?

@kenji-miyake In Autoware.Auto, as long as an MR had an approval, anyone could merge it from the members. With the help of merge-bot.

@kenji-miyake
Copy link
Contributor

@xmfcx Thank you, I understand.

Hmm, then I think I can add a CI workflow that can do the same thing as merge-bot, but I'll merge this by myself for now.
I'll consider other ways in the future.

@kenji-miyake kenji-miyake merged commit 7681249 into autowarefoundation:main Apr 12, 2022
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Apr 13, 2022
Merged
@brkay54 brkay54 deleted the add-genesis-joystick-to-joy-controller branch April 13, 2022 11:03
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@brkay54 @pre-commit-ci @boyali
feat(joy_controller): adding genesis joystick to joy controller (tier…
de3eafe 
…4#683)

* feat(joy_controller): add genesis p65 converter

Signed-off-by: Berkay <berkay@leodrive.ai>

* feat(joy_controller): fix steering direction

Signed-off-by: Berkay <berkay@leodrive.ai>

* feat(joy_controller): changed map

Signed-off-by: Berkay <berkay@leodrive.ai>

* ci(pre-commit): autofix

Co-authored-by: Berkay <berkay@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@brkay54 @pre-commit-ci @boyali
feat(joy_controller): adding genesis joystick to joy controller (tier…
b96f415 
…4#683)

* feat(joy_controller): add genesis p65 converter

Signed-off-by: Berkay <berkay@leodrive.ai>

* feat(joy_controller): fix steering direction

Signed-off-by: Berkay <berkay@leodrive.ai>

* feat(joy_controller): changed map

Signed-off-by: Berkay <berkay@leodrive.ai>

* ci(pre-commit): autofix

Co-authored-by: Berkay <berkay@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@brkay54 @pre-commit-ci @boyali
feat(joy_controller): adding genesis joystick to joy controller (tier…
b70344f 
…4#683)

* feat(joy_controller): add genesis p65 converter

Signed-off-by: Berkay <berkay@leodrive.ai>

* feat(joy_controller): fix steering direction

Signed-off-by: Berkay <berkay@leodrive.ai>

* feat(joy_controller): changed map

Signed-off-by: Berkay <berkay@leodrive.ai>

* ci(pre-commit): autofix

Co-authored-by: Berkay <berkay@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@brkay54 @pre-commit-ci @boyali
feat(joy_controller): adding genesis joystick to joy controller (tier…
49721e5 
…4#683)

* feat(joy_controller): add genesis p65 converter

Signed-off-by: Berkay <berkay@leodrive.ai>

* feat(joy_controller): fix steering direction

Signed-off-by: Berkay <berkay@leodrive.ai>

* feat(joy_controller): changed map

Signed-off-by: Berkay <berkay@leodrive.ai>

* ci(pre-commit): autofix

Co-authored-by: Berkay <berkay@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Jul 26, 2023
@tkimura4 @TomohitoAndo @pre-commit-ci
feat(behavior_velocity): support new traffic signal interface (autowa…
f30df97 
…refoundation#683)

* feat(behavior_velocity): support new traffic signal interface

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* style(pre-commit): autofix

* add missing dependency

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* style(pre-commit): autofix

* remove the external signal input source in behavior_planning_launch.py

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* replace TrafficLightElement with TrafficSignalElement

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* style(pre-commit): autofix

* use the regulatory element id instead of traffic light id

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* change the input of traffic signal to traffic light arbiter

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* style(pre-commit): autofix

* do not return until the all regulatory elements are checked

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Co-authored-by: Tomohito Ando <tomohito.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenji-miyake kenji-miyake kenji-miyake approved these changes

Assignees

@brkay54 brkay54

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brkay54 @kenji-miyake @xmfcx