Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pointcloud based probabilistic occupancy grid map #624

Conversation

yukkysaito
Copy link
Contributor

@yukkysaito yukkysaito commented Apr 2, 2022

Signed-off-by: Yukihiro Saito yukky.saito@gmail.com

Description

Added a node implementing the new occupancy grid methodology. The detailed method of the node is described here.

readme is here

Peek 2022-04-02 01-32

Related links

#582 (comment)

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

yukkysaito and others added 2 commits April 2, 2022 20:33
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #624 (9a3da1d) into main (61a09b8) will decrease coverage by 10.66%.
The diff coverage is 0.00%.

❗ Current head 9a3da1d differs from pull request most recent head 6975f04. Consider uploading reports for the commit 6975f04 to get more accurate results

@@            Coverage Diff             @@
##             main    #624       +/-   ##
==========================================
- Coverage   10.66%   0.00%   -10.67%     
==========================================
  Files         729      10      -719     
  Lines       51075     766    -50309     
  Branches     6572       0     -6572     
==========================================
- Hits         5445       0     -5445     
+ Misses      41223     766    -40457     
+ Partials     4407       0     -4407     
Impacted Files Coverage Δ
...bilistic_occupancy_grid_map/include/cost_value.hpp 0.00% <ø> (ø)
...id_map/laserscan_based_occupancy_grid_map_node.hpp 0.00% <ø> (ø)
...id_map/laserscan_based_occupancy_grid_map_node.cpp 0.00% <0.00%> (ø)
...an_based_occupancy_grid_map/occupancy_grid_map.cpp 0.00% <ø> (ø)
...ud_based_occupancy_grid_map/occupancy_grid_map.cpp 0.00% <0.00%> (ø)
...d_map/pointcloud_based_occupancy_grid_map_node.cpp 0.00% <0.00%> (ø)
...occupancy_grid_map_binary_bayes_filter_updater.cpp 0.00% <ø> (ø)
...ude/object_detection/predicted_objects_display.hpp
...nner/src/scene_module/no_stopping_area/manager.cpp
...mon/autoware_auto_common/test/test_angle_utils.cpp
... and 718 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05d0131...6975f04. Read the comment docs.

yukkysaito and others added 11 commits April 4, 2022 01:22
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
…com:yukkysaito/autoware.universe into feature/pointcloud_based_occupancy_grid_map
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
…upancy_grid_map' into feature/pointcloud_based_occupancy_grid_map
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
@yukkysaito yukkysaito marked this pull request as ready for review April 4, 2022 12:01
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
tested by real vehicle in experiment
image (4)

@yukkysaito yukkysaito merged commit 0b70df0 into autowarefoundation:main Apr 8, 2022
taikitanaka3 referenced this pull request in tier4/autoware.universe Apr 9, 2022
* initial commit

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* change param

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add launch

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* fix typo

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* cosmetic change

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add single frame mode

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
taikitanaka3 referenced this pull request in tier4/autoware.universe Apr 14, 2022
* initial commit

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* change param

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add launch

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* fix typo

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* cosmetic change

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add single frame mode

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
taikitanaka3 referenced this pull request in tier4/autoware.universe Apr 14, 2022
* initial commit

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* change param

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add launch

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* fix typo

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* cosmetic change

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add single frame mode

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* initial commit

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* change param

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add launch

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* fix typo

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* cosmetic change

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add single frame mode

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* initial commit

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* change param

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add launch

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* fix typo

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* cosmetic change

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add single frame mode

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* initial commit

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* change param

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add launch

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* fix typo

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* cosmetic change

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add single frame mode

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* initial commit

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* change param

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add launch

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* fix typo

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* update readme

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* cosmetic change

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add single frame mode

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
knzo25 pushed a commit to knzo25/autoware.universe that referenced this pull request Jul 3, 2023
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants