Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity): occlusion spot generate not detection area occupancy grid #620

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Apr 1, 2022

Description

  • new feature
    • generate not detection area occupancy grid from dynamic object

concept moving vehicle will interrupt obstacle running out behind moving vehicle
Screenshot from 2022-04-01 16-50-21

white: occupied
black: freespace
gray: unkown

image

This PR is going to

  • consider delay of dynamic object briefly
    This PR wont
  • consider delay of dynamic object accurately

Related links

tier4/autoware_launch#282

Tests performed

by psim

Notes for reviewers

testing raycast all vehicle

test raycast for all vehicle
Screenshot from 2022-04-01 16-39-49

test raycast only moving vehicle
Screenshot from 2022-04-01 16-50-21

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@taikitanaka3 taikitanaka3 force-pushed the 258-feat-behavior-velocity-occlusion-spot-generate-Not-detection-area-occupancy-grid branch from 3305c02 to 608fdbd Compare April 4, 2022 01:39
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #620 (5988206) into main (23cb41a) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
- Coverage   10.59%   10.55%   -0.04%     
==========================================
  Files         735      736       +1     
  Lines       51761    52085     +324     
  Branches     6596     6757     +161     
==========================================
+ Hits         5482     5499      +17     
- Misses      41819    42124     +305     
- Partials     4460     4462       +2     
Flag Coverage Δ *Carryforward flag
differential 6.29% <0.00%> (?)
total 10.59% <0.00%> (ø) Carriedforward from 2772082

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/scene_module/occlusion_spot/grid_utils.hpp 0.00% <0.00%> (ø)
...ene_module/occlusion_spot/occlusion_spot_utils.hpp 37.50% <ø> (+12.50%) ⬆️
...ner/src/scene_module/occlusion_spot/grid_utils.cpp 12.37% <0.00%> (-4.42%) ⬇️
...lanner/src/scene_module/occlusion_spot/manager.cpp 0.00% <0.00%> (ø)
...ene_module/occlusion_spot/occlusion_spot_utils.cpp 6.89% <0.00%> (-2.79%) ⬇️
...ene_module/occlusion_spot/scene_occlusion_spot.cpp 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23cb41a...5988206. Read the comment docs.

@taikitanaka3 taikitanaka3 force-pushed the 258-feat-behavior-velocity-occlusion-spot-generate-Not-detection-area-occupancy-grid branch from 608fdbd to e0c02de Compare April 9, 2022 11:01
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
…in detection area

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 force-pushed the 258-feat-behavior-velocity-occlusion-spot-generate-Not-detection-area-occupancy-grid branch from b47061d to 7e86623 Compare April 13, 2022 11:37
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
yukkysaito
yukkysaito previously approved these changes Apr 13, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 enabled auto-merge (squash) April 14, 2022 04:53
@taikitanaka3 taikitanaka3 merged commit fac209b into autowarefoundation:main Apr 14, 2022
@taikitanaka3 taikitanaka3 deleted the 258-feat-behavior-velocity-occlusion-spot-generate-Not-detection-area-occupancy-grid branch April 14, 2022 05:12
taikitanaka3 referenced this pull request in tier4/autoware.universe Apr 14, 2022
…ccupancy grid (#620)

* feat(behavior_velocity): filter dynamic object by default

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(behavior_velocity): raycast object shadow

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): replace target vehicle to filtered vehicle in detection area

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): update docs and settings

* chore(behavior_velocity): cosmetic change

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): consider delay for detection

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix(behavior_velocity): fix launch and stuck vehicle

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): use experiment value

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): add comment

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
taikitanaka3 referenced this pull request in tier4/autoware.universe Apr 14, 2022
…ccupancy grid (#620)

* feat(behavior_velocity): filter dynamic object by default

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(behavior_velocity): raycast object shadow

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): replace target vehicle to filtered vehicle in detection area

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): update docs and settings

* chore(behavior_velocity): cosmetic change

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): consider delay for detection

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix(behavior_velocity): fix launch and stuck vehicle

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): use experiment value

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): add comment

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…ccupancy grid (tier4#620)

* feat(behavior_velocity): filter dynamic object by default

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(behavior_velocity): raycast object shadow

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): replace target vehicle to filtered vehicle in detection area

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): update docs and settings

* chore(behavior_velocity): cosmetic change

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): consider delay for detection

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix(behavior_velocity): fix launch and stuck vehicle

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): use experiment value

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): add comment

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ccupancy grid (tier4#620)

* feat(behavior_velocity): filter dynamic object by default

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(behavior_velocity): raycast object shadow

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): replace target vehicle to filtered vehicle in detection area

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): update docs and settings

* chore(behavior_velocity): cosmetic change

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): consider delay for detection

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix(behavior_velocity): fix launch and stuck vehicle

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): use experiment value

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): add comment

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ccupancy grid (tier4#620)

* feat(behavior_velocity): filter dynamic object by default

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(behavior_velocity): raycast object shadow

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): replace target vehicle to filtered vehicle in detection area

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): update docs and settings

* chore(behavior_velocity): cosmetic change

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): consider delay for detection

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix(behavior_velocity): fix launch and stuck vehicle

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): use experiment value

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): add comment

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…ccupancy grid (tier4#620)

* feat(behavior_velocity): filter dynamic object by default

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(behavior_velocity): raycast object shadow

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): replace target vehicle to filtered vehicle in detection area

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): update docs and settings

* chore(behavior_velocity): cosmetic change

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): consider delay for detection

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix(behavior_velocity): fix launch and stuck vehicle

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): use experiment value

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): add comment

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jul 3, 2023
…owarefoundation#620)

* fix(lane_change): fix minimum lane change length (autowarefoundation#4033)

* fix(lane_change): dont cut centerline but insert stop (autowarefoundation#3999)

* fix(lane_change): dont cut centerline but insert stop

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* style(pre-commit): autofix

* removed duplicated

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* old arch by default

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix old architecture

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* style(pre-commit): autofix

* hard code stop buffer distance and insert macro

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* use macro for old architecture

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: Yutaka Shimizu <43805014+purewater0901@users.noreply.github.com>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants