Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(motion_velocity_smoother): revert loading smoother params from node #614

Conversation

mkuri
Copy link
Contributor

@mkuri mkuri commented Mar 31, 2022

Description

The following commit (2b8d5fc) changed the way parameters are reflected in order to call smoother from other nodes. However, it interferes with the function to dynamically change parameters, so revert.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #614 (071c065) into main (a8025f0) will decrease coverage by 10.74%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #614       +/-   ##
==========================================
- Coverage   10.74%   0.00%   -10.75%     
==========================================
  Files         713      10      -703     
  Lines       50670    1800    -48870     
  Branches     6572       0     -6572     
==========================================
- Hits         5445       0     -5445     
+ Misses      40818    1800    -39018     
+ Partials     4407       0     -4407     
Impacted Files Coverage Δ
...ity_smoother/src/motion_velocity_smoother_node.cpp 0.00% <0.00%> (ø)
..._smoother/analytical_jerk_constrained_smoother.cpp 0.00% <0.00%> (ø)
...y_smoother/src/smoother/jerk_filtered_smoother.cpp 0.00% <0.00%> (ø)
..._smoother/src/smoother/l2_pseudo_jerk_smoother.cpp 0.00% <0.00%> (ø)
...moother/src/smoother/linf_pseudo_jerk_smoother.cpp 0.00% <0.00%> (ø)
...n_velocity_smoother/src/smoother/smoother_base.cpp 0.00% <ø> (ø)
...toware_auto_geometry/include/geometry/interval.hpp
localization/ndt/include/ndt/pcl_modified.hpp
perception/tensorrt_yolo/lib/src/trt_yolo.cpp
... and 700 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8025f0...071c065. Read the comment docs.

@mkuri mkuri enabled auto-merge (squash) April 1, 2022 05:13
@mkuri mkuri disabled auto-merge April 1, 2022 06:20
@mkuri mkuri closed this Apr 1, 2022
@mkuri mkuri deleted the fix/revert-loading-smoother-params-from-node-instance branch April 1, 2022 08:22
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants