Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tier4_planning_rviz_plugin): add PathWithLaneId rviz plugin #591

Merged
merged 3 commits into from
Mar 28, 2022
Merged

feat(tier4_planning_rviz_plugin): add PathWithLaneId rviz plugin #591

merged 3 commits into from
Mar 28, 2022

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Mar 28, 2022 •
edited
Loading

Description

Add PathWithLaneId to tier4_planning_rviz_plugin.

Related links

https://github.com/tier4/autoware.iv/pull/2343

Tests performed

I confirmed that PathWithLaneId can be visualized.
Screenshot from 2022-03-28 13-27-35

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@tier4-autoware-private-bot @h-ohta
@kenji-miyake @kosuke55
sync rc rc/v1.7.1 (autowarefoundation#2345)
03327d9 
* add behavior_path_rviz_plugin (autowarefoundation#2343)

* add behavior_path_rviz_plugin

* edit README

* fix for uncrustify

* fix include guard

* use autoware_lint_common

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Revert "use autoware_lint_common"

This reverts commit 98c264d5f32d88fb19cd7953fc64a2052648af29.

* fix for cpplint

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Fix format

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 changed the title Feature/path with lane id rviz plugin feat(tier4_planning_rviz_plugin): add PathWithLaneId rviz plugin Mar 28, 2022
@kosuke55 kosuke55 force-pushed the feature/path_with_lane_id_rviz_plugin branch from 1b52770 to 80d8265 Compare March 28, 2022 04:39
@kosuke55
Merge remote-tracking branch 'kosuke55/feature/rename_behavior_path_r…
6b85c32 
…viz_plugin' into tmp/feature/path_with_lane_id_rviz_plugin
@codecov
Copy link

codecov bot commented Mar 28, 2022 •
edited
Loading

Codecov Report

Merging #591 (3e589fe) into main (007487a) will decrease coverage by 10.91%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #591       +/-   ##
==========================================
- Coverage   10.91%   0.00%   -10.92%     
==========================================
  Files         706      12      -694     
  Lines       49835    1188    -48647     
  Branches     7116       0     -7116     
==========================================
- Hits         5438       0     -5438     
+ Misses      40016    1188    -38828     
+ Partials     4381       0     -4381
Impacted Files Coverage Δ
...ning_rviz_plugin/src/path_with_lane_id/display.cpp 0.00% <0.00%> (ø)
...apollo_instance_segmentation/feature_generator.hpp
...e_auto_geometry/test/include/test_bounding_box.hpp
..._planner/src/scene_module/intersection/manager.cpp
...th_planner/scene_module/scene_module_interface.hpp
localization/ndt/include/ndt/pcl_modified.hpp
...ior_path_planner/src/path_shifter/path_shifter.cpp
planning/motion_velocity_smoother/src/resample.cpp
...r4_vehicle_rviz_plugin/src/tools/console_meter.cpp
.../src/distortion_corrector/distortion_corrector.cpp
... and 686 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007487a...3e589fe. Read the comment docs.

@kosuke55
feat(tier4_planning_rviz_plugin): add PathWithLaneId rviz plugin
3e589fe 
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feature/path_with_lane_id_rviz_plugin branch from 80d8265 to 3e589fe Compare March 28, 2022 04:55
@kosuke55 kosuke55 merged commit 0b5734f into autowarefoundation:main Mar 28, 2022
@kosuke55 kosuke55 mentioned this pull request Mar 28, 2022
Merged
4 tasks
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Mar 29, 2022
Merged
kosuke55 added a commit to kosuke55/autoware.universe that referenced this pull request Jun 9, 2022
@kosuke55 @tier4-autoware-private-bot
@h-ohta @kenji-miyake
feat(tier4_planning_rviz_plugin): add PathWithLaneId rviz plugin (aut…
c581f93 
…owarefoundation#591)

* sync rc rc/v1.7.1 (autowarefoundation#2345)

* add behavior_path_rviz_plugin (autowarefoundation#2343)

* add behavior_path_rviz_plugin

* edit README

* fix for uncrustify

* fix include guard

* use autoware_lint_common

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Revert "use autoware_lint_common"

This reverts commit 98c264d5f32d88fb19cd7953fc64a2052648af29.

* fix for cpplint

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Fix format

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(tier4_planning_rviz_plugin): add PathWithLaneId rviz plugin

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@kosuke55 @tier4-autoware-private-bot
@h-ohta @kenji-miyake @boyali
feat(tier4_planning_rviz_plugin): add PathWithLaneId rviz plugin (tie…
26ddc03 
…r4#591)

* sync rc rc/v1.7.1 (autowarefoundation#2345)

* add behavior_path_rviz_plugin (autowarefoundation#2343)

* add behavior_path_rviz_plugin

* edit README

* fix for uncrustify

* fix include guard

* use autoware_lint_common

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Revert "use autoware_lint_common"

This reverts commit 98c264d5f32d88fb19cd7953fc64a2052648af29.

* fix for cpplint

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Fix format

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(tier4_planning_rviz_plugin): add PathWithLaneId rviz plugin

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@kosuke55 @tier4-autoware-private-bot
@h-ohta @kenji-miyake @boyali
feat(tier4_planning_rviz_plugin): add PathWithLaneId rviz plugin (tie…
5df129c 
…r4#591)

* sync rc rc/v1.7.1 (autowarefoundation#2345)

* add behavior_path_rviz_plugin (autowarefoundation#2343)

* add behavior_path_rviz_plugin

* edit README

* fix for uncrustify

* fix include guard

* use autoware_lint_common

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Revert "use autoware_lint_common"

This reverts commit 98c264d5f32d88fb19cd7953fc64a2052648af29.

* fix for cpplint

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Fix format

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(tier4_planning_rviz_plugin): add PathWithLaneId rviz plugin

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@kosuke55 @tier4-autoware-private-bot
@h-ohta @kenji-miyake @boyali
feat(tier4_planning_rviz_plugin): add PathWithLaneId rviz plugin (tie…
a608e60 
…r4#591)

* sync rc rc/v1.7.1 (autowarefoundation#2345)

* add behavior_path_rviz_plugin (autowarefoundation#2343)

* add behavior_path_rviz_plugin

* edit README

* fix for uncrustify

* fix include guard

* use autoware_lint_common

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Revert "use autoware_lint_common"

This reverts commit 98c264d5f32d88fb19cd7953fc64a2052648af29.

* fix for cpplint

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Fix format

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(tier4_planning_rviz_plugin): add PathWithLaneId rviz plugin

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@kosuke55 @tier4-autoware-private-bot
@h-ohta @kenji-miyake @boyali
feat(tier4_planning_rviz_plugin): add PathWithLaneId rviz plugin (tie…
7e9367f 
…r4#591)

* sync rc rc/v1.7.1 (autowarefoundation#2345)

* add behavior_path_rviz_plugin (autowarefoundation#2343)

* add behavior_path_rviz_plugin

* edit README

* fix for uncrustify

* fix include guard

* use autoware_lint_common

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Revert "use autoware_lint_common"

This reverts commit 98c264d5f32d88fb19cd7953fc64a2052648af29.

* fix for cpplint

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Fix format

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(tier4_planning_rviz_plugin): add PathWithLaneId rviz plugin

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
YamatoAndo pushed a commit to YamatoAndo/autoware.universe that referenced this pull request Aug 8, 2024
@sfukuta
fix(planning): fix build error (autowarefoundation#591)
5a1be89 
Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

@h-ohta h-ohta Awaiting requested review from h-ohta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kosuke55 @yukkysaito