Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trajectory_follower): change stop check speed threshold to almost 0 #473

Merged
merged 2 commits into from
Mar 23, 2022
Merged

fix(trajectory_follower): change stop check speed threshold to almost 0 #473

merged 2 commits into from
Mar 23, 2022

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Mar 3, 2022 •
edited
Loading

Related Issue(required)

The vehicle was considered to be stopped while driving at low speed, and then the steering control doesn't work.

Description(required)

Therefore, by default, this parameter is set to 0 so that the steering control always works. If one wants to enable the "steer does not move when the vehicle stops" function, set the parameters by themselves.

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@TakaHoribe
fix(trajectory_follower): change stop check speed threshold to 0
7b60421 
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested review from tkimura4 and rej55 and removed request for tkimura4 March 3, 2022 08:51
taikitanaka3 added a commit to taikitanaka3/autoware.universe that referenced this pull request Mar 3, 2022
@tkimura4 @mitsudome-r
@esteve @TakaHoribe @jilaada @k0suke-murakami @kenji-miyake @wep21 @h-ohta @isamu-takagi @KeisukeShima @pre-commit-ci @taikitanaka3
feat: add system_launch package (autowarefoundation#167)
89f05c8 
* release v0.4.0

* removed ROS1 package

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "removed ROS1 package"

This reverts commit e002b78f1e1ddf980ee7c4010918f1c117ff4be1.

* add COLCON_IGNORE file to all ROS1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* rename *.launch files to *.launch.xml

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Port to ROS 2

* Fix params file paths

* Re-add autoware_state_monitor

* Update system_launch/launch/system.launch.xml

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Add linters and missing pakcages dependencies (autowarefoundation#37)

* V0.8 system launch (autowarefoundation#51)

* tmp rename launch file

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* Add system_monitor to system.launch (autowarefoundation#72)

* Add system_monitor to system.launch

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix typo

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add config file of system_monitor (autowarefoundation#115)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add config of diagnostic_aggregator (autowarefoundation#128)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add vehicle cmd gate config (autowarefoundation#136)

* Add config_file of vehicle_cmd_gate

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add use_emergency_stop

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename emergency_stop to external_emergency_stop

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix command_gate diag

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add use_emergency_hold arg (autowarefoundation#142)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix system.launch (autowarefoundation#161)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Revert "tmp rename launch file"

This reverts commit d1bb989eac90f43bab2af6669b00638fd2147eeb.

* fix launch file

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* fix minor bug

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* rename .yaml -> .param.yaml

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* fix invalid way to use eval

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* Add new line in yaml

* add num_disks

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* rename .yaml to .param.yaml

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Rename ROS-related .yaml to .param.yaml (autowarefoundation#65)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add missing '--'

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix livox param name

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add clock_publisher and autoware_version (autowarefoundation#79)

* add clock_publisher and autoware_version

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* update package.xml

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* update build_depends.repos

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix CI

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Split system_monitor config (autowarefoundation#98)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add use_sim-time option (autowarefoundation#99)

* Replace doc by description (autowarefoundation#182)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Use set_parameter for use_sim_time (autowarefoundation#198)

* Use set_parameter for use_sim_time

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add default parameter for scenario simulator

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* change system_monitor.launch.xml to launch.py (autowarefoundation#203)

* add README.md and svg files (autowarefoundation#328)

* add md and svg

* fix typo

* fix typo

* fix word

* fix typo

* add lack of things

* Update README

* fix depending packages

* fix word

* Fix pre-commit (autowarefoundation#407)

* Fix pre-commit errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix package.xml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Update system.launch.xml (autowarefoundation#411)

* Feature/autoware api autoware versions (autowarefoundation#438)

* Add package version API

* Fix message type

* Modify api name

* use let variable in system_launch (autowarefoundation#473)

* Add sensor_model to system_launch (autowarefoundation#480)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change formatter to black (autowarefoundation#488)

* Update pre-commit settings

* Apply Black

* Replace ament_lint_common with autoware_lint_common

* Update build_depends.repos

* Fix build_depends

* Fix diagnostic_aggregator config path (autowarefoundation#118)

* update param

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* update readme

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Esteve Fernandez <esteve@apache.org>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Jilada Eccleston <jilada.eccleston@tier4.jp>
Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
@wep21
Copy link
Contributor

wep21 commented Mar 22, 2022

@TakaHoribe Some tests are failed. Please check them out.

@TakaHoribe
change default parameter
716b385 
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe mentioned this pull request Mar 23, 2022
Merged
8 tasks
@TakaHoribe TakaHoribe changed the title fix(trajectory_follower): change stop check speed threshold to 0 fix(trajectory_follower): change stop check speed threshold to almost 0 Mar 23, 2022
@TakaHoribe
Copy link
Contributor Author

@wep21 Test for stop condition was failed. It can pass by setting a suitable parameter on test, but I think almost zero (but non zero) value is more appropriate for this parameter.

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #473 (716b385) into main (1bab84e) will increase coverage by 24.35%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #473       +/-   ##
===========================================
+ Coverage   10.99%   35.34%   +24.35%     
===========================================
  Files         704        7      -697     
  Lines       49493     1372    -48121     
  Branches     6647      850     -5797     
===========================================
- Hits         5440      485     -4955     
+ Misses      39693      161    -39532     
+ Partials     4360      726     -3634
Impacted Files Coverage Δ
.../include/traffic_light_map_based_detector/node.hpp
common/had_map_utils/src/had_map_visualization.cpp
...apollo_instance_segmentation/feature_generator.hpp
...tion/tensorrt_yolo/lib/src/plugins/mish_plugin.cpp
...oware_auto_geometry/include/geometry/common_2d.hpp
..._simulator/test/test_simple_planning_simulator.cpp
...n/shape_estimation/lib/corrector/car_corrector.cpp
...nalysis/src/control_performance_analysis_utils.cpp
...de/system_monitor/cpu_monitor/cpu_monitor_base.hpp
...er/scene_module/scene_module_bt_node_interface.hpp
... and 687 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bab84e...716b385. Read the comment docs.

rej55
rej55 approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rej55 rej55 merged commit 007487a into autowarefoundation:main Mar 23, 2022
@rej55 rej55 deleted the fix/default-parameter-mpc branch March 23, 2022 05:59
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Mar 24, 2022
Merged
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@TakaHoribe @boyali
fix(trajectory_follower): change stop check speed threshold to almost…
5c97d59 
… 0 (tier4#473)

* fix(trajectory_follower): change stop check speed threshold to 0

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* change default parameter

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@TakaHoribe @boyali
fix(trajectory_follower): change stop check speed threshold to almost…
b071042 
… 0 (tier4#473)

* fix(trajectory_follower): change stop check speed threshold to 0

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* change default parameter

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
@KeisukeShima
use let variable in system_launch (autowarefoundation#473)
6cd7bef
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@TakaHoribe @boyali
fix(trajectory_follower): change stop check speed threshold to almost…
43ceb42 
… 0 (tier4#473)

* fix(trajectory_follower): change stop check speed threshold to 0

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* change default parameter

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
tkimura4 referenced this pull request in tier4/autoware.universe Oct 24, 2022
@kosuke55
feat(behavior_path_planner): change pull over params (#473)
ce9ad9f 
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
@yukke42
feat(autoware_launch): update pointpainting param (autowarefoundation…
5b820f7 
…#473)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
HansOersted pushed a commit to HansOersted/autoware.universe that referenced this pull request Mar 8, 2024
@saka1-s
chore: update beta/v2.3.0 (autowarefoundation#473)
a6c8047 
[universe]
33dbaa4 feat(tier4_perception_launch): make switchable detection by tracker in x2 project (autowarefoundation#964)
940fb2b Merge pull request autowarefoundation#965 from tier4/beta/v0.11.0+PR5356
5aa9db1 feat(map_based_prediction): remove crossing fence path (autowarefoundation#5356)
[common]
c3a1a19 fix(visualization): display traffic reg elem id (autowarefoundation#210)
36b3825 feat(lanelet2_extention): add getAllFences (autowarefoundation#209)
44dc388 docs(lanelet2_extension): add brief description for crosswalk traffic light (autowarefoundation#208)
c360614 feat(lanelet2_extensions): add query curbstones from vector map (autowarefoundation#206)
[launcher]
a2f88f00 feat(autoware_launch): longer prediction 15.0 -> 20.0 (autowarefoundation#482)
87974c0f fix: fix stop_duration_sec param for merge_from_private (autowarefoundation#516)
f5a1dfad fix(autoware_launch): fix parameter for light weight grand segmentation (autowarefoundation#506)
YamatoAndo pushed a commit to YamatoAndo/autoware.universe that referenced this pull request Aug 8, 2024
@h-ohta @pre-commit-ci
fix(fault_injection): fix build error in Humble (autowarefoundation#473)
475aa3c 
* fix(fault_injection): fix build error in Humble

* ci(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rej55 rej55 rej55 approved these changes

@tkimura4 tkimura4 Awaiting requested review from tkimura4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TakaHoribe @wep21 @rej55