chore(dual return outlier filter): update package.xml #331

satoshi-ota · 2022-02-02T02:52:00Z

Related Issue(required)

Description(required)

bug fix
we have to add cv_bridge to package.xmk in order to use dual return outlier filter.

Review Procedure(required)

update aip_x2_launch/launch/lidar.launch.xml Strongest -> Dual

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Read commit-guidelines
Assign PR to reviewer

If you are adding new package following items are required:

Documentation with description of the package is available
A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

Commits are properly organized and messages are according to the guideline
PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

codecov-commenter · 2022-02-02T03:19:57Z

Codecov Report

Merging #331 (fecefb5) into tier4/proposal (c65c057) will decrease coverage by 9.85%.
The diff coverage is n/a.

❗ Current head fecefb5 differs from pull request most recent head 7533df9. Consider uploading reports for the commit 7533df9 to get more accurate results

@@                Coverage Diff                @@
##           tier4/proposal    #331      +/-   ##
=================================================
- Coverage            9.85%   0.00%   -9.86%     
=================================================
  Files                 661      42     -619     
  Lines               47111    2797   -44314     
  Branches             5805       0    -5805     
=================================================
- Hits                 4641       0    -4641     
+ Misses              38606    2797   -35809     
+ Partials             3864       0    -3864

Impacted Files	Coverage Δ
...ner/src/scene_module/avoidance/avoidance_utils.cpp
map/lanelet2_extension/test/src/test_utilities.cpp
...c/vehicle_model/vehicle_model_bicycle_dynamics.cpp
...or_path_planner/src/behavior_path_planner_node.cpp
...rtest_path/mu_successive_shortest_path_wrapper.cpp
...nning_simulator/simple_planning_simulator_core.hpp
...t_tracker/tracker/model/normal_vehicle_tracker.hpp
...ude/shape_estimation/corrector/truck_corrector.hpp
...association/solver/mu_successive_shortest_path.hpp
.../src/goal_pose_visualizer/goal_pose_visualizer.cpp
... and 609 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c65c057...7533df9. Read the comment docs.

1222-takeshi

LGTM

…tion#331) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* add integration launch (autowarefoundation#55) * Feature/add ci launch (autowarefoundation#60) * add integration launch * feat: add integration launch for PSim CI * feat: update for planning_simulator_launcher/scenario_launcher.launch Co-authored-by: hiroyuki.obinata <hiroyuki.obinata@tier4.jp> * Add sensor_model and vehicle_model Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * removed ROS1 package Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "removed ROS1 package" This reverts commit 7b71f0d645b8c5286944f60db7cd9d4a434c6e24. * add COLCON_IGNORE file to all ROS1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * rename *.launch files to *.launch.xml Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * fix ci (autowarefoundation#180) * fix ci * add space * fix format * Format launch files (autowarefoundation#228) * Format launch files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Format launch.py Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix lint Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fixup for autowarefoundation#217 (autowarefoundation#254) * Fixup for autowarefoundation#217 Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix typo Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add description for integration_launch (autowarefoundation#331) * add description * fix sentence * add README.md and svg files (autowarefoundation#328) * add md and svg * fix typo * fix typo * fix word * fix typo * add lack of things * Update README * fix depending packages * fix word * Fix pre-commit (autowarefoundation#407) * Fix pre-commit errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix package.xml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change formatter to black (autowarefoundation#488) * Update pre-commit settings * Apply Black * Replace ament_lint_common with autoware_lint_common * Update build_depends.repos * Fix build_depends * remove scenario_runner Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com> Co-authored-by: Makoto Tokunaga <vios-fish@users.noreply.github.com> Co-authored-by: hiroyuki.obinata <hiroyuki.obinata@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>

…tion#331) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* add integration launch (autowarefoundation#55) * Feature/add ci launch (autowarefoundation#60) * add integration launch * feat: add integration launch for PSim CI * feat: update for planning_simulator_launcher/scenario_launcher.launch Co-authored-by: hiroyuki.obinata <hiroyuki.obinata@tier4.jp> * Add sensor_model and vehicle_model Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * removed ROS1 package Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "removed ROS1 package" This reverts commit 7b71f0d645b8c5286944f60db7cd9d4a434c6e24. * add COLCON_IGNORE file to all ROS1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * rename *.launch files to *.launch.xml Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * fix ci (autowarefoundation#180) * fix ci * add space * fix format * Format launch files (autowarefoundation#228) * Format launch files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Format launch.py Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix lint Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fixup for autowarefoundation#217 (autowarefoundation#254) * Fixup for autowarefoundation#217 Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix typo Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add description for integration_launch (autowarefoundation#331) * add description * fix sentence * add README.md and svg files (autowarefoundation#328) * add md and svg * fix typo * fix typo * fix word * fix typo * add lack of things * Update README * fix depending packages * fix word * Fix pre-commit (autowarefoundation#407) * Fix pre-commit errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix package.xml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change formatter to black (autowarefoundation#488) * Update pre-commit settings * Apply Black * Replace ament_lint_common with autoware_lint_common * Update build_depends.repos * Fix build_depends * remove scenario_runner Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com> Co-authored-by: Makoto Tokunaga <vios-fish@users.noreply.github.com> Co-authored-by: hiroyuki.obinata <hiroyuki.obinata@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>

…tion#331) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* add integration launch (autowarefoundation#55) * Feature/add ci launch (autowarefoundation#60) * add integration launch * feat: add integration launch for PSim CI * feat: update for planning_simulator_launcher/scenario_launcher.launch Co-authored-by: hiroyuki.obinata <hiroyuki.obinata@tier4.jp> * Add sensor_model and vehicle_model Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * removed ROS1 package Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "removed ROS1 package" This reverts commit 7b71f0d645b8c5286944f60db7cd9d4a434c6e24. * add COLCON_IGNORE file to all ROS1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * rename *.launch files to *.launch.xml Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * fix ci (autowarefoundation#180) * fix ci * add space * fix format * Format launch files (autowarefoundation#228) * Format launch files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Format launch.py Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix lint Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fixup for autowarefoundation#217 (autowarefoundation#254) * Fixup for autowarefoundation#217 Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix typo Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add description for integration_launch (autowarefoundation#331) * add description * fix sentence * add README.md and svg files (autowarefoundation#328) * add md and svg * fix typo * fix typo * fix word * fix typo * add lack of things * Update README * fix depending packages * fix word * Fix pre-commit (autowarefoundation#407) * Fix pre-commit errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix package.xml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change formatter to black (autowarefoundation#488) * Update pre-commit settings * Apply Black * Replace ament_lint_common with autoware_lint_common * Update build_depends.repos * Fix build_depends * remove scenario_runner Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com> Co-authored-by: Makoto Tokunaga <vios-fish@users.noreply.github.com> Co-authored-by: hiroyuki.obinata <hiroyuki.obinata@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>

* add description * fix sentence

* chore: sync files (autowarefoundation#311) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * feat: disable namespace `lane_start_bound` (autowarefoundation#314) * feat: disable lane_bound * fix: lane_start_bound * feat: add center_line_arrows to disable * ci: add sync-awf.yaml (autowarefoundation#318) * ci: add sync-awf.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * rename Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * refactor(vehicle_cmd_gate): add namespace (autowarefoundation#316) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * style: fix flake8 C417 (autowarefoundation#321) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * chore(behavior_velocity): update latest params (autowarefoundation#320) * chore(behavior_velocity): update latest params Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ci(pre-commit): autoupdate (autowarefoundation#324) updates: - [github.com/tier4/pre-commit-hooks-ros: v0.7.0 → v0.7.1](tier4/pre-commit-hooks-ros@v0.7.0...v0.7.1) - [github.com/scop/pre-commit-shfmt: v3.4.3-1 → v3.5.0-1](scop/pre-commit-shfmt@v3.4.3-1...v3.5.0-1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(autoware_api_launch): add rtc controller (autowarefoundation#305) * add rtc controller Signed-off-by: tkhmy <tkh.my.p@gmail.com> * change line Signed-off-by: tkhmy <tkh.my.p@gmail.com> * change back to alphabetical order Signed-off-by: tkhmy <tkh.my.p@gmail.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kah Hooi Tan <41041286+tkhmy@users.noreply.github.com>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

…tc-auto-mode fix(rtc_interface): fix initial auto mode (autowarefoundation#3029)

chore(dual return outlier filter): update package.xml

7533df9

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

satoshi-ota force-pushed the chore/update-depends branch from fecefb5 to 7533df9 Compare February 2, 2022 02:54

satoshi-ota requested a review from 1222-takeshi February 2, 2022 02:56

satoshi-ota marked this pull request as ready for review February 2, 2022 02:56

1222-takeshi approved these changes Feb 2, 2022

View reviewed changes

satoshi-ota merged commit 579a4dc into autowarefoundation:tier4/proposal Feb 2, 2022

satoshi-ota deleted the chore/update-depends branch February 2, 2022 06:59

satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Feb 2, 2022

chore(dual return outlier filter): update package.xml (autowarefounda…

7eeaaa2

…tion#331) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

satoshi-ota referenced this pull request in tier4/autoware.universe Feb 2, 2022

chore(dual return outlier filter): update package.xml (#331) (#8)

08b5207

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 4, 2022

chore(dual return outlier filter): update package.xml (autowarefounda…

cd863ea

…tion#331) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 4, 2022

chore(dual return outlier filter): update package.xml (autowarefounda…

18f5002

…tion#331) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

wep21 mentioned this pull request Feb 8, 2022

chore: sync upstream tier4/autoware.universe#5

Merged

TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022

add description for integration_launch (autowarefoundation#331)

f30548a

* add description * fix sentence

KYabuuchi pushed a commit to KYabuuchi/autoware.universe that referenced this pull request Feb 16, 2023

ci(docker): add rosdistro to image names (autowarefoundation#331)

1447719

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

mkuri added a commit to mkuri/autoware.universe that referenced this pull request Mar 22, 2023

Merge pull request autowarefoundation#331 from tier4/fix/initialize-r…

3f563c7

…tc-auto-mode fix(rtc_interface): fix initial auto mode (autowarefoundation#3029)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(dual return outlier filter): update package.xml #331

chore(dual return outlier filter): update package.xml #331

satoshi-ota commented Feb 2, 2022 •

edited

Loading

codecov-commenter commented Feb 2, 2022 •

edited

Loading

1222-takeshi left a comment

chore(dual return outlier filter): update package.xml #331

chore(dual return outlier filter): update package.xml #331

Conversation

satoshi-ota commented Feb 2, 2022 • edited Loading

Related Issue(required)

Description(required)

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-Review Checklist for the PR Author

CI Checks

codecov-commenter commented Feb 2, 2022 • edited Loading

Codecov Report

1222-takeshi left a comment

Choose a reason for hiding this comment

satoshi-ota commented Feb 2, 2022 •

edited

Loading

codecov-commenter commented Feb 2, 2022 •

edited

Loading