Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static_centerline_optimizer): fixed TODOs and implemented changed interfaces #2294

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Nov 15, 2022

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added document component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Nov 15, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the fix/static-centerline-optimizer branch from b0e50ea to 2af6acb Compare November 15, 2022 11:06
@github-actions github-actions bot removed the document label Nov 15, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 10.55% // Head: 10.93% // Increases project coverage by +0.37% 🎉

Coverage data is based on head (3a57c50) compared to base (3d714ac).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 3a57c50 differs from pull request most recent head c165115. Consider uploading reports for the commit c165115 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2294      +/-   ##
==========================================
+ Coverage   10.55%   10.93%   +0.37%     
==========================================
  Files        1256     1217      -39     
  Lines       91029    88134    -2895     
  Branches    20790    21156     +366     
==========================================
+ Hits         9611     9640      +29     
+ Misses      71260    68448    -2812     
+ Partials    10158    10046     -112     
Flag Coverage Δ *Carryforward flag
differential 2.78% <0.00%> (?)
total 11.05% <0.00%> (+0.52%) ⬆️ Carriedforward from c165115

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...y_smoother/src/smoother/jerk_filtered_smoother.cpp 0.00% <0.00%> (ø)
..._cruise_planner/pid_based_planner/debug_values.hpp 0.00% <ø> (ø)
...se_planner/pid_based_planner/pid_based_planner.hpp 0.00% <0.00%> (ø)
...lanner/src/pid_based_planner/pid_based_planner.cpp 0.00% <0.00%> (ø)
...optimizer/src/static_centerline_optimizer_node.cpp 0.00% <0.00%> (ø)
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 64.15% <0.00%> (-18.87%) ⬇️
...ene_module/occlusion_spot/occlusion_spot_utils.hpp 54.54% <0.00%> (-2.60%) ⬇️
planning/behavior_path_planner/src/utilities.cpp 3.81% <0.00%> (-0.10%) ⬇️
planning/route_handler/src/route_handler.cpp 0.00% <0.00%> (ø)
.../behavior_path_planner/src/turn_signal_decider.cpp 35.93% <0.00%> (ø)
... and 67 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the fix/static-centerline-optimizer branch from ef86b3f to c165115 Compare November 21, 2022 02:55
@takayuki5168 takayuki5168 marked this pull request as ready for review November 21, 2022 02:56
@takayuki5168 takayuki5168 requested a review from a team as a code owner November 21, 2022 02:56
@takayuki5168 takayuki5168 changed the title fixed TODOs and implemented changed interfaces fix(static_centerline_optimizer): fixed TODOs and implemented changed interfaces Nov 21, 2022
@takayuki5168 takayuki5168 merged commit bf04632 into autowarefoundation:main Nov 21, 2022
@takayuki5168 takayuki5168 deleted the fix/static-centerline-optimizer branch November 21, 2022 06:59
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
… interfaces (autowarefoundation#2294)

* fixed TODOs and implemented changed interfaces

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* revert route_handler

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
… interfaces (autowarefoundation#2294)

* fixed TODOs and implemented changed interfaces

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* revert route_handler

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
… interfaces (autowarefoundation#2294)

* fixed TODOs and implemented changed interfaces

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* revert route_handler

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant