Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ndt_scan_matcher): modularize pose initialization #2254

Merged
merged 25 commits into from
Nov 10, 2022
Merged

refactor(ndt_scan_matcher): modularize pose initialization #2254

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
184eb9f
still work in progress
kminoda Nov 8, 2022
4d29996
updated
kminoda Nov 8, 2022
3ab08a5
ci(pre-commit): autofix
pre-commit-ci[bot] Nov 8, 2022
b70327e
ptr_ptr yameru
kminoda Nov 9, 2022
d266dc2
resolve conflict
kminoda Nov 9, 2022
07e54dd
remove unnecessary newline
kminoda Nov 9, 2022
500081c
revert launch setting
kminoda Nov 9, 2022
1fb3ab5
ci(pre-commit): autofix
pre-commit-ci[bot] Nov 9, 2022
1514769
reverted debugging line
kminoda Nov 9, 2022
0282885
Merge branch 'refactor/ndt_scan_matcher/modularize_map_callback' of g…
kminoda Nov 9, 2022
179f692
pre-commit
kminoda Nov 9, 2022
d7e4c7a
remove format inclusion
kminoda Nov 9, 2022
c3449df
first commit on pose initialization module
kminoda Nov 9, 2022
bbd61d3
use shared_ptr for test
kminoda Nov 9, 2022
5c1ed7e
now works fine
kminoda Nov 9, 2022
acab3a7
resolve conflict
kminoda Nov 9, 2022
6d443d5
ci(pre-commit): autofix
pre-commit-ci[bot] Nov 9, 2022
626ad07
No StdMap
kminoda Nov 9, 2022
cd0e904
resolve conflict
kminoda Nov 9, 2022
0614bcf
ci(pre-commit): autofix
pre-commit-ci[bot] Nov 9, 2022
27a87a7
added include
kminoda Nov 10, 2022
3d0017a
Merge branch 'refactor/ndt_scan_matcher/modularize_initialization' of…
kminoda Nov 10, 2022
622fc8c
ci(pre-commit): autofix
pre-commit-ci[bot] Nov 10, 2022
2b8359f
reflected review
kminoda Nov 10, 2022
bd737ad
Merge branch 'refactor/ndt_scan_matcher/modularize_initialization' of…
kminoda Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ci(pre-commit): autofix
  • Loading branch information
@pre-commit-ci
pre-commit-ci[bot] committed Nov 9, 2022
commit 1fb3ab590bce0cf875e146514ce80a520a812200
3 changes: 1 addition & 2 deletions localization/ndt_scan_matcher/src/map_module.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ MapModule::MapModule(
rclcpp::Node * node, std::mutex * ndt_ptr_mutex,
std::shared_ptr<NormalDistributionsTransform> ndt_ptr,
rclcpp::CallbackGroup::SharedPtr map_callback_group)
: ndt_ptr_(ndt_ptr),
ndt_ptr_mutex_(ndt_ptr_mutex)
: ndt_ptr_(ndt_ptr), ndt_ptr_mutex_(ndt_ptr_mutex)
{
auto map_sub_opt = rclcpp::SubscriptionOptions();
map_sub_opt.callback_group = map_callback_group;
Expand Down