fix: sync stored_commands to cooperate status

[tkimura4]

Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp

Description

In rtc_interface, stored_commands is updated only when onCooperateCommandService() is called and is_locked_ is true.
However, the stored_commands are copied to the cooperate command status every time unlockCommandUpdate() is called.

void RTCInterface::unlockCommandUpdate()
{
is_locked_ = false;
updateCooperateCommandStatus(stored_commands_);
}

As a result, the cooperate commands that are cleared once may be re-registered through stored_commands_.
I fixed this by properly clearing the stored_command.

Note: This bug is caused by performing lane-change in the same direction more than once.

Related links

Tests performed

Using planning simulator, set the lane change module to RTC Approval mode and make sure that a lane change is not performed without approval.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Base: 11.89% // Head: 11.89% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (8dcdb38) compared to base (7c9f6e2).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2223      +/-   ##
==========================================
- Coverage   11.89%   11.89%   -0.01%     
==========================================
  Files        1111     1111              
  Lines       80812    80834      +22     
  Branches    20737    20750      +13     
==========================================
  Hits         9614     9614              
- Misses      61072    61094      +22     
  Partials    10126    10126              

Flag	Coverage Δ		*Carryforward flag
differential	3.85% <0.00%> (?)
total	11.86% <0.00%> (ø)		Carriedforward from 7c9f6e2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
planning/rtc_interface/src/rtc_interface.cpp	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[rej55]

LGTM

[satoshi-ota]

The PR worked without any problems in the actual vehicle test.