fix(behavior_path_planner): fix offset sign expanding side shift drivable area #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime-clem
added
the
component:planning
maxime-clem
force-pushed
the
fix-behavior_path_planner-expand_drivable_area-sign
branch
from
b46dc02
to
c5a28ef
Compare
Codecov ReportBase: 11.09% // Head: 11.09% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2196 +/- ##
==========================================
- Coverage 11.09% 11.09% -0.01%
==========================================
Files 1202 1202
Lines 86170 86171 +1
Branches 20680 20680
==========================================
Hits 9558 9558
- Misses 66661 66662 +1
Partials 9951 9951
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
maxime-clem
force-pushed
the
fix-behavior_path_planner-expand_drivable_area-sign
branch
from
c5a28ef
to
d437e2c
Compare
maxime-clem
changed the title
…rivable area Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
force-pushed
the
fix-behavior_path_planner-expand_drivable_area-sign
branch
from
d437e2c
to
b1b6d2c
Compare
maxime-clem
requested review from
rej55,
kosuke55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
3 tasks
|
drivable area is created successfully |
maxime-clem
deleted the
fix-behavior_path_planner-expand_drivable_area-sign
branch
HansRobo
pushed a commit
to HansRobo/autoware.universe
that referenced
this pull request
Dec 16, 2022
…able area (autowarefoundation#2196) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
YoshiRi
pushed a commit
to YoshiRi/autoware.universe
that referenced
this pull request
Jan 11, 2023
…able area (autowarefoundation#2196) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Function
lanelet::utils::getExpandedLanelets, used to expand a lanelet, expects positive left/right offsets.The code of the side shift module calculates a negative value.
This PR sets its sign to be positive instead.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.