Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(pre-commit): format SVG files #2172

Merged
merged 3 commits into from
Oct 28, 2022
Merged

ci(pre-commit): format SVG files #2172

merged 3 commits into from
Oct 28, 2022

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented Oct 27, 2022 •
edited
Loading

Description

Since it is easier to check spelling errors, I'd like to apply Prettier to SVG files.
As this PR changes many packages, I'll merge this using admin rights after getting approvals from some maintainers.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Kenji Miyake and others added 2 commits October 28, 2022 08:09
ci(pre-commit): format SVG files
c320468 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@pre-commit-ci
ci(pre-commit): autofix
f4095a7
apply pre-commit
1a5403d 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
shmpwk
shmpwk approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenji-miyake
Copy link
Contributor Author

kenji-miyake commented Oct 27, 2022 •
edited
Loading

The core change is only c320468, and it's from https://github.com/tier4/pre-commit-hooks-ros/blob/ba80754516f108570ba2ccd5e5faad038bfe6947/.pre-commit-hooks.yaml.

I'll move this local hook to autoware-pre-commit-hooks, which is a new repository, in the future.

TomohitoAndo
TomohitoAndo approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenji-miyake
Copy link
Contributor Author

Without this PR:

❯ cspell control/trajectory_follower/design/media/BrakeKeeping.drawio.svg \
      planning/behavior_velocity_planner/docs/BehaviorVelocityPlanner-Architecture.drawio.svg \
      perception/radar_fusion_to_detected_object/docs/radar_fusion_to_detected_object_5.drawio.svg \
      ./sensing/pointcloud_preprocessor/docs/image/vector_map_inside_area_filter_overview.svg \
      ./planning/behavior_velocity_planner/docs/occlusion_spot/occlusion_spot.svg \
      ./planning/behavior_velocity_planner/docs/run_out/run_out_overview.svg \
      ./planning/behavior_velocity_planner/docs/run_out/collision_detection_for_shape.svg \
      ./planning/behavior_velocity_planner/docs/run_out/calculate_expected_target_velocity.svg \
      ./planning/behavior_velocity_planner/docs/run_out/exclude_obstacles_by_partition.svg \
      ./planning/behavior_velocity_planner/docs/run_out/collision_points.svg \
      ./planning/behavior_velocity_planner/docs/run_out/insert_velocity.svg \
      ./planning/behavior_velocity_planner/docs/run_out/create_dynamic_obstacle.svg \
      ./planning/behavior_velocity_planner/docs/run_out/insert_velocity_to_approach.svg
 1/13 ./control/trajectory_follower/design/media/BrakeKeeping.drawio.svg 274.42ms
 2/13 ./planning/behavior_velocity_planner/docs/BehaviorVelocityPlanner-Architecture.drawio.svg 146.67ms X
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/BehaviorVelocityPlanner-Architecture.drawio.svg:473:33 - Unknown word (Stoplin)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/BehaviorVelocityPlanner-Architecture.drawio.svg:479:21 - Unknown word (Stoplin)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/BehaviorVelocityPlanner-Architecture.drawio.svg:1437:41 - Unknown word (Ligh)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/BehaviorVelocityPlanner-Architecture.drawio.svg:1443:29 - Unknown word (Ligh)
 3/13 ./perception/radar_fusion_to_detected_object/docs/radar_fusion_to_detected_object_5.drawio.svg 20.27ms X
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/perception/radar_fusion_to_detected_object/docs/radar_fusion_to_detected_object_5.drawio.svg:156:52 - Unknown word (obejct)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/perception/radar_fusion_to_detected_object/docs/radar_fusion_to_detected_object_5.drawio.svg:166:28 - Unknown word (obejct)
 4/13 ./sensing/pointcloud_preprocessor/docs/image/vector_map_inside_area_filter_overview.svg 42.77ms
 5/13 ./planning/behavior_velocity_planner/docs/occlusion_spot/occlusion_spot.svg 461.32ms
 6/13 ./planning/behavior_velocity_planner/docs/run_out/run_out_overview.svg 55.49ms
 7/13 ./planning/behavior_velocity_planner/docs/run_out/collision_detection_for_shape.svg 229.95ms
 8/13 ./planning/behavior_velocity_planner/docs/run_out/calculate_expected_target_velocity.svg 13.11ms
 9/13 ./planning/behavior_velocity_planner/docs/run_out/exclude_obstacles_by_partition.svg 24.72ms
10/13 ./planning/behavior_velocity_planner/docs/run_out/collision_points.svg 72.03ms
11/13 ./planning/behavior_velocity_planner/docs/run_out/insert_velocity.svg 39.74ms
12/13 ./planning/behavior_velocity_planner/docs/run_out/create_dynamic_obstacle.svg 65.77ms
13/13 ./planning/behavior_velocity_planner/docs/run_out/insert_velocity_to_approach.svg 36.17ms
CSpell: Files checked: 13, Issues found: 6 in 2 files

With this PR:

❯ cspell control/trajectory_follower/design/media/BrakeKeeping.drawio.svg \
      planning/behavior_velocity_planner/docs/BehaviorVelocityPlanner-Architecture.drawio.svg \
      perception/radar_fusion_to_detected_object/docs/radar_fusion_to_detected_object_5.drawio.svg \
      ./sensing/pointcloud_preprocessor/docs/image/vector_map_inside_area_filter_overview.svg \
      ./planning/behavior_velocity_planner/docs/occlusion_spot/occlusion_spot.svg \
      ./planning/behavior_velocity_planner/docs/run_out/run_out_overview.svg \
      ./planning/behavior_velocity_planner/docs/run_out/collision_detection_for_shape.svg \
      ./planning/behavior_velocity_planner/docs/run_out/calculate_expected_target_velocity.svg \
      ./planning/behavior_velocity_planner/docs/run_out/exclude_obstacles_by_partition.svg \
      ./planning/behavior_velocity_planner/docs/run_out/collision_points.svg \
      ./planning/behavior_velocity_planner/docs/run_out/insert_velocity.svg \
      ./planning/behavior_velocity_planner/docs/run_out/create_dynamic_obstacle.svg \
      ./planning/behavior_velocity_planner/docs/run_out/insert_velocity_to_approach.svg
 1/13 ./control/trajectory_follower/design/media/BrakeKeeping.drawio.svg 274.63ms
 2/13 ./planning/behavior_velocity_planner/docs/BehaviorVelocityPlanner-Architecture.drawio.svg 137.81ms X
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/BehaviorVelocityPlanner-Architecture.drawio.svg:532:17 - Unknown word (Stoplin)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/BehaviorVelocityPlanner-Architecture.drawio.svg:537:112 - Unknown word (Stoplin)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/BehaviorVelocityPlanner-Architecture.drawio.svg:1575:25 - Unknown word (Ligh)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/BehaviorVelocityPlanner-Architecture.drawio.svg:1580:120 - Unknown word (Ligh)
 3/13 ./perception/radar_fusion_to_detected_object/docs/radar_fusion_to_detected_object_5.drawio.svg 19.65ms X
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/perception/radar_fusion_to_detected_object/docs/radar_fusion_to_detected_object_5.drawio.svg:190:50 - Unknown word (obejct)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/perception/radar_fusion_to_detected_object/docs/radar_fusion_to_detected_object_5.drawio.svg:198:120 - Unknown word (obejct)
 4/13 ./sensing/pointcloud_preprocessor/docs/image/vector_map_inside_area_filter_overview.svg 50.41ms
 5/13 ./planning/behavior_velocity_planner/docs/occlusion_spot/occlusion_spot.svg 48.06ms
 6/13 ./planning/behavior_velocity_planner/docs/run_out/run_out_overview.svg 78.61ms X
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/run_out_overview.svg:28:634 - Unknown word (progid)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/run_out_overview.svg:28:668 - Unknown word (dropshadow)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/run_out_overview.svg:32:297 - Unknown word (MSIE)
 7/13 ./planning/behavior_velocity_planner/docs/run_out/collision_detection_for_shape.svg 170.99ms X
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/collision_detection_for_shape.svg:28:634 - Unknown word (progid)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/collision_detection_for_shape.svg:28:668 - Unknown word (dropshadow)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/collision_detection_for_shape.svg:32:297 - Unknown word (MSIE)
 8/13 ./planning/behavior_velocity_planner/docs/run_out/calculate_expected_target_velocity.svg 27.02ms X
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/calculate_expected_target_velocity.svg:28:634 - Unknown word (progid)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/calculate_expected_target_velocity.svg:28:668 - Unknown word (dropshadow)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/calculate_expected_target_velocity.svg:32:297 - Unknown word (MSIE)
 9/13 ./planning/behavior_velocity_planner/docs/run_out/exclude_obstacles_by_partition.svg 37.77ms X
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/exclude_obstacles_by_partition.svg:28:634 - Unknown word (progid)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/exclude_obstacles_by_partition.svg:28:668 - Unknown word (dropshadow)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/exclude_obstacles_by_partition.svg:32:297 - Unknown word (MSIE)
10/13 ./planning/behavior_velocity_planner/docs/run_out/collision_points.svg 83.73ms X
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/collision_points.svg:28:634 - Unknown word (progid)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/collision_points.svg:28:668 - Unknown word (dropshadow)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/collision_points.svg:32:297 - Unknown word (MSIE)
11/13 ./planning/behavior_velocity_planner/docs/run_out/insert_velocity.svg 57.89ms X
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/insert_velocity.svg:28:634 - Unknown word (progid)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/insert_velocity.svg:28:668 - Unknown word (dropshadow)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/insert_velocity.svg:32:297 - Unknown word (MSIE)
12/13 ./planning/behavior_velocity_planner/docs/run_out/create_dynamic_obstacle.svg 98.88ms X
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/create_dynamic_obstacle.svg:28:634 - Unknown word (progid)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/create_dynamic_obstacle.svg:28:668 - Unknown word (dropshadow)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/create_dynamic_obstacle.svg:32:297 - Unknown word (MSIE)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/create_dynamic_obstacle.svg:75:44 - Unknown word (darkreader)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/create_dynamic_obstacle.svg:75:80 - Unknown word (darkreader)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/create_dynamic_obstacle.svg:79:46 - Unknown word (darkreader)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/create_dynamic_obstacle.svg:79:82 - Unknown word (darkreader)
/home/kenji/ghq/github.com/autowarefoundation/autoware.universe/planning/behavior_velocity_planner/docs/run_out/create_dynamic_obstacle.svg:83:44 - Unknown word (darkreader)
13/13 ./planning/behavior_velocity_planner/docs/run_out/insert_velocity_to_approach.svg 51.07ms
CSpell: Files checked: 13, Issues found: 32 in 9 files

Although most changes are just reserved words, it seems CSpell is working better, and the files are easy to be checked in text.

@codecov
Copy link

codecov bot commented Oct 28, 2022 •
edited
Loading

Codecov Report

Base: 10.89% // Head: 11.07% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (1a5403d) compared to base (5dc9afc).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2172      +/-   ##
==========================================
+ Coverage   10.89%   11.07%   +0.17%     
==========================================
  Files        1172     1175       +3     
  Lines       77666    79716    +2050     
  Branches    19464    19795     +331     
==========================================
+ Hits         8465     8830     +365     
- Misses      59894    61224    +1330     
- Partials     9307     9662     +355
Flag Coverage Δ *Carryforward flag
differential 9.77% <ø> (?)
total 10.89% <ø> (ø) Carriedforward from 5dc9afc

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../src/vehicle/test_vehicle_state_checker_helper.hpp 70.58% <0.00%> (-9.42%) ⬇️
planning/behavior_path_planner/test/input.cpp 60.00% <0.00%> (-7.86%) ⬇️
...city_planner/include/utilization/state_machine.hpp 31.03% <0.00%> (-7.07%) ⬇️
...include/motion_utils/trajectory/tmp_conversion.hpp 60.00% <0.00%> (-6.67%) ⬇️
...ng/behavior_path_planner/test/test_turn_signal.cpp 27.60% <0.00%> (-5.73%) ⬇️
...nning/behavior_velocity_planner/test/src/utils.hpp 82.35% <0.00%> (-4.75%) ⬇️
...or/test/src/test_planning_error_monitor_helper.hpp 45.45% <0.00%> (-4.55%) ⬇️
...ning_evaluator/include/planning_evaluator/stat.hpp 33.33% <0.00%> (-3.04%) ⬇️
...ower_nodes/test/trajectory_follower_test_utils.hpp 73.33% <0.00%> (-2.53%) ⬇️
...izer/src/pose_initializer/copy_vector_to_array.hpp 36.36% <0.00%> (-1.14%) ⬇️
... and 289 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mitsudome-r
mitsudome-r approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenji-miyake kenji-miyake merged commit 67a0eba into main Oct 28, 2022
@kenji-miyake kenji-miyake deleted the format-svg branch October 28, 2022 01:55
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Oct 29, 2022
Merged
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
@kenji-miyake @pre-commit-ci @HansRobo
ci(pre-commit): format SVG files (autowarefoundation#2172)
8455e4f 
* ci(pre-commit): format SVG files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci(pre-commit): autofix

* apply pre-commit

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isamu-takagi isamu-takagi isamu-takagi approved these changes

@mitsudome-r mitsudome-r mitsudome-r approved these changes

@shmpwk shmpwk shmpwk approved these changes

@TomohitoAndo TomohitoAndo TomohitoAndo approved these changes

@yukkysaito yukkysaito yukkysaito approved these changes

@ito-san ito-san Awaiting requested review from ito-san ito-san is a code owner

@KeisukeShima KeisukeShima Awaiting requested review from KeisukeShima KeisukeShima is a code owner

@amc-nu amc-nu Awaiting requested review from amc-nu

@miursh miursh Awaiting requested review from miursh miursh is a code owner

@badai-nguyen badai-nguyen Awaiting requested review from badai-nguyen

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@purewater0901 purewater0901 Awaiting requested review from purewater0901

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

@scepter914 scepter914 Awaiting requested review from scepter914

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo YamatoAndo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kenji-miyake @yukkysaito @TomohitoAndo @shmpwk @mitsudome-r @isamu-takagi