-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ModelZoo): model descriptors versioning #2158
feat(ModelZoo): model descriptors versioning #2158
Conversation
Introduce a version field to the interface. Make use of it in the lidar_apollo_segmentation_tvm packages and the yolo_v2 example of tvm_utility. Issue-Id: SCM-4000 Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com> Change-Id: I6d666f886b0a9f01128bfa4cf30e189d23f3481e
8d99af2
to
a085961
Compare
Codecov ReportBase: 11.10% // Head: 10.77% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2158 +/- ##
==========================================
- Coverage 11.10% 10.77% -0.34%
==========================================
Files 1208 1186 -22
Lines 86573 84834 -1739
Branches 20829 19889 -940
==========================================
- Hits 9612 9138 -474
+ Misses 66805 66012 -793
+ Partials 10156 9684 -472
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Introduce a version field to the interface. Make use of it in the lidar_apollo_segmentation_tvm packages and the yolo_v2 example of tvm_utility. Issue-Id: SCM-4000 Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com> Change-Id: I6d666f886b0a9f01128bfa4cf30e189d23f3481e Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com> Co-authored-by: Xinyu Wang <93699235+angry-crab@users.noreply.github.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Introduce a version field to the interface. Make use of it in the lidar_apollo_segmentation_tvm packages and the yolo_v2 example of tvm_utility. Issue-Id: SCM-4000 Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com> Change-Id: I6d666f886b0a9f01128bfa4cf30e189d23f3481e Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com> Co-authored-by: Xinyu Wang <93699235+angry-crab@users.noreply.github.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Description
Introduce a version field to the interface. This allows to (optionally) check version of the model at runtime.
Make use of it in the lidar_apollo_segmentation_tvm packages and the yolo_v2 example of tvm_utility.
Related links
Closes #1879
Needs autowarefoundation/modelzoo#70
Tests performed
Tested with hand-crafted header files. Will need to be re-tested after autowarefoundation/modelzoo#70 is merged.Tested locally by enabling downloading the models with the
DOWNLOAD_ARTIFACTS=ON
cmake variable and running the unit tests of the modified packages.Notes for reviewers
The handling of local user models is broken. Will need changes to
tvm_utility
from #2185 to fix it.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.