Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ModelZoo): model descriptors versioning #2158

Merged

Conversation

ambroise-arm
Copy link
Contributor

@ambroise-arm ambroise-arm commented Oct 26, 2022

Description

Introduce a version field to the interface. This allows to (optionally) check version of the model at runtime.

Make use of it in the lidar_apollo_segmentation_tvm packages and the yolo_v2 example of tvm_utility.

Related links

Closes #1879

Needs autowarefoundation/modelzoo#70

Tests performed

Tested with hand-crafted header files. Will need to be re-tested after autowarefoundation/modelzoo#70 is merged.

Tested locally by enabling downloading the models with the DOWNLOAD_ARTIFACTS=ON cmake variable and running the unit tests of the modified packages.

Notes for reviewers

The handling of local user models is broken. Will need changes to tvm_utility from #2185 to fix it.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Introduce a version field to the interface.

Make use of it in the lidar_apollo_segmentation_tvm packages and the
yolo_v2 example of tvm_utility.

Issue-Id: SCM-4000
Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com>
Change-Id: I6d666f886b0a9f01128bfa4cf30e189d23f3481e
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 11.10% // Head: 10.77% // Decreases project coverage by -0.33% ⚠️

Coverage data is based on head (8d99af2) compared to base (a2bcd7c).
Patch has no changes to coverable lines.

❗ Current head 8d99af2 differs from pull request most recent head 091f82a. Consider uploading reports for the commit 091f82a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2158      +/-   ##
==========================================
- Coverage   11.10%   10.77%   -0.34%     
==========================================
  Files        1208     1186      -22     
  Lines       86573    84834    -1739     
  Branches    20829    19889     -940     
==========================================
- Hits         9612     9138     -474     
+ Misses      66805    66012     -793     
+ Partials    10156     9684     -472     
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 10.74% <ø> (-0.33%) ⬇️ Carriedforward from 41f47be

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
vehicle/raw_vehicle_cmd_converter/src/pid.cpp 0.00% <0.00%> (-85.72%) ⬇️
...onverter/include/raw_vehicle_cmd_converter/pid.hpp 0.00% <0.00%> (-66.67%) ⬇️
...lude/behavior_path_planner/turn_signal_decider.hpp 50.00% <0.00%> (-35.72%) ⬇️
...rajectory_follower/pid_longitudinal_controller.hpp 0.00% <0.00%> (-28.58%) ⬇️
...include/perception_utils/object_classification.hpp 50.00% <0.00%> (-18.75%) ⬇️
...ng/behavior_path_planner/test/test_turn_signal.cpp 27.60% <0.00%> (-12.81%) ⬇️
...ehicle/raw_vehicle_cmd_converter/src/brake_map.cpp 33.33% <0.00%> (-11.83%) ⬇️
...tion/include/interpolation/interpolation_utils.hpp 56.66% <0.00%> (-5.10%) ⬇️
..._converter/test/test_raw_vehicle_cmd_converter.cpp 27.77% <0.00%> (-3.81%) ⬇️
...tion_utils/test/src/test_object_classification.cpp 16.12% <0.00%> (-1.08%) ⬇️
... and 156 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ambroise-arm ambroise-arm marked this pull request as ready for review November 3, 2022 09:58
Copy link
Contributor

@angry-crab angry-crab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angry-crab angry-crab enabled auto-merge (squash) November 11, 2022 04:46
@angry-crab angry-crab merged commit fd7add5 into autowarefoundation:main Nov 11, 2022
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
Introduce a version field to the interface.

Make use of it in the lidar_apollo_segmentation_tvm packages and the
yolo_v2 example of tvm_utility.

Issue-Id: SCM-4000
Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com>
Change-Id: I6d666f886b0a9f01128bfa4cf30e189d23f3481e

Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com>
Co-authored-by: Xinyu Wang <93699235+angry-crab@users.noreply.github.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
Introduce a version field to the interface.

Make use of it in the lidar_apollo_segmentation_tvm packages and the
yolo_v2 example of tvm_utility.

Issue-Id: SCM-4000
Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com>
Change-Id: I6d666f886b0a9f01128bfa4cf30e189d23f3481e

Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com>
Co-authored-by: Xinyu Wang <93699235+angry-crab@users.noreply.github.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align TVM packages with ModelZoo changes
2 participants