-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pid_longitudinal_controller): add diag for control state #2092
feat(pid_longitudinal_controller): add diag for control state #2092
Conversation
06374b0
to
09cc3fb
Compare
Codecov ReportBase: 10.37% // Head: 10.52% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2092 +/- ##
==========================================
+ Coverage 10.37% 10.52% +0.15%
==========================================
Files 1175 1176 +1
Lines 84040 84313 +273
Branches 19591 19757 +166
==========================================
+ Hits 8717 8874 +157
- Misses 65787 65806 +19
- Partials 9536 9633 +97
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
control/trajectory_follower/src/pid_longitudinal_controller_diagnostic.cpp
Outdated
Show resolved
Hide resolved
control/trajectory_follower/src/pid_longitudinal_controller.cpp
Outdated
Show resolved
Hide resolved
08f8a5d
to
894cdfa
Compare
af3f271
to
dbe05c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ito-san Could you review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@takayuki5168 @TakaHoribe Could you merge this? |
@h-ohta Don't we have to create a PR to tier4/autoware_launch? |
@takayuki5168 Could you tell me what change I have to add? |
@h-ohta |
@takayuki5168 |
Description
This PR adds diagnostic for control state. It allows us to notify error when control state is emergency state.
There are some sample images.
OK
Translation is larger than threshold
Rotation is larger than threshold
Related links
TierIV Internal Link
https://tier4.atlassian.net/browse/T4PB-20935
Tests performed
ros2 run rqt_robot_monitor rqt_robot_monitor
controller_node: control_state
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.