Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pid_longitudinal_controller): add diag for control state #2092

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Oct 18, 2022

Description

This PR adds diagnostic for control state. It allows us to notify error when control state is emergency state.
There are some sample images.

OK

2022-10-18_16-59_2

Translation is larger than threshold

2022-10-18_16-59_1

Rotation is larger than threshold

2022-10-18_16-59

Related links

TierIV Internal Link

https://tier4.atlassian.net/browse/T4PB-20935

Tests performed

  • launch psim
  • set 2d pose estimate and 2d nav goal
  • launch ros2 run rqt_robot_monitor rqt_robot_monitor
  • confirm controller_node: control_state
  • move ego pose in some positions

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta force-pushed the feature/longitudinal_controller_diag branch from 06374b0 to 09cc3fb Compare October 18, 2022 08:01
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 10.37% // Head: 10.52% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (2c6e587) compared to base (0a01850).
Patch coverage: 58.06% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2092      +/-   ##
==========================================
+ Coverage   10.37%   10.52%   +0.15%     
==========================================
  Files        1175     1176       +1     
  Lines       84040    84313     +273     
  Branches    19591    19757     +166     
==========================================
+ Hits         8717     8874     +157     
- Misses      65787    65806      +19     
- Partials     9536     9633      +97     
Flag Coverage Δ *Carryforward flag
differential 39.02% <51.85%> (?)
total 10.35% <88.88%> (ø) Carriedforward from 0a01850

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...rajectory_follower/pid_longitudinal_controller.hpp 0.00% <0.00%> (ø)
...ctory_follower/src/pid_longitudinal_controller.cpp 43.37% <60.00%> (+6.26%) ⬆️
...odel/vehicle_model_bicycle_kinematics_no_delay.cpp 89.65% <0.00%> (-1.65%) ⬇️
control/trajectory_follower/src/mpc.cpp 48.43% <0.00%> (+0.29%) ⬆️
...vehicle_model/vehicle_model_bicycle_kinematics.cpp 86.84% <0.00%> (+2.97%) ⬆️
...ctory_follower/include/trajectory_follower/mpc.hpp 56.00% <0.00%> (+9.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@h-ohta h-ohta marked this pull request as ready for review October 18, 2022 08:47
@h-ohta h-ohta force-pushed the feature/longitudinal_controller_diag branch from 08f8a5d to 894cdfa Compare October 21, 2022 06:17
@h-ohta h-ohta force-pushed the feature/longitudinal_controller_diag branch from af3f271 to dbe05c9 Compare October 21, 2022 06:38
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168
Copy link
Contributor

@ito-san Could you review this PR

Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@h-ohta
Copy link
Contributor Author

h-ohta commented Oct 24, 2022

@takayuki5168 @TakaHoribe Could you merge this?

@takayuki5168
Copy link
Contributor

@h-ohta Don't we have to create a PR to tier4/autoware_launch?

@h-ohta
Copy link
Contributor Author

h-ohta commented Oct 24, 2022

@takayuki5168 Could you tell me what change I have to add?

@takayuki5168
Copy link
Contributor

@h-ohta
yaml file. If the change of yaml file has to be applied to tier4/autoware_launch.

@h-ohta
Copy link
Contributor Author

h-ohta commented Oct 24, 2022

@takayuki5168
We don't need some changes for tier4/autoware_launch because it uses control.param.yaml in system_error_monitor as it is.

@takayuki5168 takayuki5168 merged commit b56938f into autowarefoundation:main Oct 24, 2022
@h-ohta h-ohta deleted the feature/longitudinal_controller_diag branch October 24, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants