-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update readme of outlier filter (#758) #208
Conversation
* add outlier filter readme template * wip * wip * replace image to drawio.svg * delete doc of occupancy_grid_map_filter in outlier_filter * update voxel_grid_outlier_filter * remove occupancy grid map outlier filter svg * update readme * fix ring outlier filter image * add dual_return_outlier_filter readme * fix readme * update dual-return-outlier-filter readme Co-authored-by: yukke42 <muramatsuyusuke9542@gmail.com>
| Name | Type | Description | | ||
| ---------------------------------------------- | ------------------------------------------ | ------------------------------------------------------- | | ||
| `/dual_return_outlier_filter/frequency_image` | `sensor_msgs::msg::Image` | The histogram image that represent visibility | | ||
| `/dual_return_outlier_filter/visibility` | `autoware_debug_msgs::msg::Float32Stamped` | A representation of visibility with a value from 0 to 1 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
autoware_debug_msgs -> tier4_debug_msgs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed at d44cd10
sensing/pointcloud_preprocessor/docs/dual-return-outlier-filter.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* release v0.4.0 * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit 6ab6bcca1dea5065fcb06aeec107538dad1f62af. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Rename launch files to launch.xml (autowarefoundation#28) * ROS2 Porting: dummy_diag_publisher (autowarefoundation#69) * Fix CMake, package.xml and remove COLCON_IGNORE * First pass - Remove ROS references: dynamic_configuration - Can compile * Fix references to dynamic_reconfigure - Clean up comments in cmake and package.xml - Add timer callback * Modify config yamls and remove dynamic reconfigure file - Fix launch files * Fix declaration of parameters using get parameters - Add rqt_reconfigure to package deps * Add comment in launch file * Remove fmt dependency * Address PR comment: - Ensure that status value is initialised properly Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> * Address PR comment: - Ensure config are declared to ensure it can be set in the parameter callback Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> * Address PR comment: - Remove headers from executable generation in cmake * Address PR comment: - Remove headers specification Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * Add linters (autowarefoundation#208) * Rename ROS-related .yaml to .param.yaml (autowarefoundation#352) * Rename ROS-related .yaml to .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove prefix 'default_' of yaml files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename vehicle_info.yaml to vehicle_info.param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename diagnostic_aggregator's param files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix overlooked parameters Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add use_sim-time option (autowarefoundation#454) * Fix for rolling (autowarefoundation#1226) * Replace doc by description Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Replace ns by push-ros-namespace Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Cleanup dummy_diag_publisher (autowarefoundation#1392) * Cleanup dummy_diag_publisher Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix typo Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Make double and write comment Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Set hardware_id from diag_name * Add const to daig_name and hardware_id Co-authored-by: kosuke55 <kosuke.tnp@gmail.com> * suppress warnings for declare parameters (autowarefoundation#1724) * fix for lanelet2_extension * fix for traffic light ssd fine detector * fix for topic_state_monitor * fix for dummy diag publisher * fix for remote cmd converter * fix for vehicle_info_util * fix for multi object tracker * fix for freespace planner * fix for autoware_error_monitor * add Werror for multi object tracker * fix for multi object tracker * add Werror for liraffic light ssd fine detector * add Werror for topic state monitor * add Werror * add Werror * add Werror * add Werror * fix style * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * Fix typo `obstacle_crush` to `obstacle_crash` (autowarefoundation#2031) * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Refactor dummy_diag_publisher (autowarefoundation#2151) * Refactor dummy_diag_publisher * fix depend order * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * remove COLCON_IGNORE in dummy_diag_publisher (autowarefoundation#528) * add README in dummy diag publisher (autowarefoundation#627) Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
…arefoundation#208) * docs: update readme of outlier filter (autowarefoundation#758) * add outlier filter readme template * wip * wip * replace image to drawio.svg * delete doc of occupancy_grid_map_filter in outlier_filter * update voxel_grid_outlier_filter * remove occupancy grid map outlier filter svg * update readme * fix ring outlier filter image * add dual_return_outlier_filter readme * fix readme * update dual-return-outlier-filter readme Co-authored-by: yukke42 <muramatsuyusuke9542@gmail.com> * Update sensing/pointcloud_preprocessor/docs/dual-return-outlier-filter.md * ci(pre-commit): autofix Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: yukke42 <muramatsuyusuke9542@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
* release v0.4.0 * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit 6ab6bcca1dea5065fcb06aeec107538dad1f62af. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Rename launch files to launch.xml (autowarefoundation#28) * ROS2 Porting: dummy_diag_publisher (autowarefoundation#69) * Fix CMake, package.xml and remove COLCON_IGNORE * First pass - Remove ROS references: dynamic_configuration - Can compile * Fix references to dynamic_reconfigure - Clean up comments in cmake and package.xml - Add timer callback * Modify config yamls and remove dynamic reconfigure file - Fix launch files * Fix declaration of parameters using get parameters - Add rqt_reconfigure to package deps * Add comment in launch file * Remove fmt dependency * Address PR comment: - Ensure that status value is initialised properly Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> * Address PR comment: - Ensure config are declared to ensure it can be set in the parameter callback Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> * Address PR comment: - Remove headers from executable generation in cmake * Address PR comment: - Remove headers specification Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * Add linters (autowarefoundation#208) * Rename ROS-related .yaml to .param.yaml (autowarefoundation#352) * Rename ROS-related .yaml to .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove prefix 'default_' of yaml files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename vehicle_info.yaml to vehicle_info.param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename diagnostic_aggregator's param files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix overlooked parameters Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add use_sim-time option (autowarefoundation#454) * Fix for rolling (autowarefoundation#1226) * Replace doc by description Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Replace ns by push-ros-namespace Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Cleanup dummy_diag_publisher (autowarefoundation#1392) * Cleanup dummy_diag_publisher Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix typo Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Make double and write comment Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Set hardware_id from diag_name * Add const to daig_name and hardware_id Co-authored-by: kosuke55 <kosuke.tnp@gmail.com> * suppress warnings for declare parameters (autowarefoundation#1724) * fix for lanelet2_extension * fix for traffic light ssd fine detector * fix for topic_state_monitor * fix for dummy diag publisher * fix for remote cmd converter * fix for vehicle_info_util * fix for multi object tracker * fix for freespace planner * fix for autoware_error_monitor * add Werror for multi object tracker * fix for multi object tracker * add Werror for liraffic light ssd fine detector * add Werror for topic state monitor * add Werror * add Werror * add Werror * add Werror * fix style * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * Fix typo `obstacle_crush` to `obstacle_crash` (autowarefoundation#2031) * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Refactor dummy_diag_publisher (autowarefoundation#2151) * Refactor dummy_diag_publisher * fix depend order * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * remove COLCON_IGNORE in dummy_diag_publisher (autowarefoundation#528) * add README in dummy diag publisher (autowarefoundation#627) Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
…arefoundation#208) * docs: update readme of outlier filter (autowarefoundation#758) * add outlier filter readme template * wip * wip * replace image to drawio.svg * delete doc of occupancy_grid_map_filter in outlier_filter * update voxel_grid_outlier_filter * remove occupancy grid map outlier filter svg * update readme * fix ring outlier filter image * add dual_return_outlier_filter readme * fix readme * update dual-return-outlier-filter readme Co-authored-by: yukke42 <muramatsuyusuke9542@gmail.com> * Update sensing/pointcloud_preprocessor/docs/dual-return-outlier-filter.md * ci(pre-commit): autofix Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: yukke42 <muramatsuyusuke9542@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
…-state-plugin chore: cherry pick adapi support for rviz state plugin
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* Add comment in update-rc-branch.yml * Change default RC version
[universe] 33dbaa4 feat(tier4_perception_launch): make switchable detection by tracker in x2 project (autowarefoundation#964) 940fb2b Merge pull request autowarefoundation#965 from tier4/beta/v0.11.0+PR5356 5aa9db1 feat(map_based_prediction): remove crossing fence path (autowarefoundation#5356) [common] c3a1a19 fix(visualization): display traffic reg elem id (autowarefoundation#210) 36b3825 feat(lanelet2_extention): add getAllFences (autowarefoundation#209) 44dc388 docs(lanelet2_extension): add brief description for crosswalk traffic light (autowarefoundation#208) c360614 feat(lanelet2_extensions): add query curbstones from vector map (autowarefoundation#206) [launcher] a2f88f00 feat(autoware_launch): longer prediction 15.0 -> 20.0 (autowarefoundation#482) 87974c0f fix: fix stop_duration_sec param for merge_from_private (autowarefoundation#516) f5a1dfad fix(autoware_launch): fix parameter for light weight grand segmentation (autowarefoundation#506)
add outlier filter readme template
wip
wip
replace image to drawio.svg
delete doc of occupancy_grid_map_filter in outlier_filter
update voxel_grid_outlier_filter
remove occupancy grid map outlier filter svg
update readme
fix ring outlier filter image
add dual_return_outlier_filter readme
fix readme
update dual-return-outlier-filter readme
Co-authored-by: yukke42 muramatsuyusuke9542@gmail.com
Related Issue(required)
Description(required)
Review Procedure(required)
Related PR(optional)
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
If you are adding new package following items are required:
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks