-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_debug_rviz_plugin): pie chart with float32 multi array stamped #2055
feat(tier4_debug_rviz_plugin): pie chart with float32 multi array stamped #2055
Conversation
…rayStamped Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@@ -0,0 +1,193 @@ | |||
// Copyright (c) 2014, JSK Lab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is included in some packages in autoware.universe.
This should be refactored with another PR.
https://github.com/autowarefoundation/autoware.universe/blob/main/common/tier4_planning_rviz_plugin/src/tools/jsk_overlay_utils.cpp
https://github.com/autowarefoundation/autoware.universe/blob/main/common/tier4_vehicle_rviz_plugin/src/tools/jsk_overlay_utils.cpp
@yukkysaito @tkimura4 Could you review this PR. |
Codecov ReportBase: 10.44% // Head: 10.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2055 +/- ##
==========================================
- Coverage 10.44% 10.39% -0.05%
==========================================
Files 1163 1166 +3
Lines 83164 83530 +366
Branches 19546 19546
==========================================
Hits 8686 8686
- Misses 64974 65340 +366
Partials 9504 9504
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
5ed38fd
to
25805d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…mped (autowarefoundation#2055) * feat(tier4_debug_rviz_plugin): add ros2 pie chart with Float32MultiArrayStamped Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update README.md Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix typo Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fixed license Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * removed unnecessary include Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
Description
pie chart from tier4_debug_msgs::msg::Float32MultiArrayStamped based on jsk_rviz_plugins (BSD license)
This plugin is useful to visualize the data of debug messages like obstacle_cruise_planner's, longitudinal_controller's, lateral_controller's, etc.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.