refactor(behavior_path_planner): change shift point to shift line #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yutaka <purewater0901@gmail.com>
purewater0901
requested review from
rej55,
kosuke55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4 and
zulfaqar-azmi-t4
as code owners
Codecov ReportBase: 10.42% // Head: 10.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2043 +/- ##
==========================================
- Coverage 10.42% 10.22% -0.20%
==========================================
Files 1169 1169
Lines 83528 85262 +1734
Branches 19555 20797 +1242
==========================================
+ Hits 8705 8721 +16
- Misses 65319 66914 +1595
- Partials 9504 9627 +123
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
If not changing behaviors, |
...avior_path_planner/include/behavior_path_planner/scene_module/avoidance/avoidance_module.hpp
Show resolved
Hide resolved
purewater0901
changed the title
|
@purewater0901
Just curious, why |
satoshi-ota
approved these changes
Oct 11, 2022
|
@zulfaqar-azmi-t4 I am not sure. Could you ask @TakaHoribe-san? |
TakaHoribe
approved these changes
Oct 11, 2022
|
Internal test 820/825 |
7 tasks
scepter914
pushed a commit
to scepter914/autoware.universe
that referenced
this pull request
Nov 1, 2022
…towarefoundation#2043) feat(behavior_path_planner): change shift point to shift line Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yutaka purewater0901@gmail.com
Description
Currently, ShiftPoint has several points in it, which makes it difficult to understand the meaning of this variable. In this PR, I renamed it to ShiftLine to make the meaning of this variable clearer.
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.