refactor(ekf_localizer): add functions to compute the pose and twist covariances #2018
+157
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IshitaTakeshi
requested review from
kminoda,
TakaHoribe and
YamatoAndo
as code owners
IshitaTakeshi
added
the
component:localization
Codecov ReportBase: 10.34% // Head: 10.32% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2018 +/- ##
==========================================
- Coverage 10.34% 10.32% -0.03%
==========================================
Files 1162 1163 +1
Lines 82730 82892 +162
Branches 19271 19392 +121
==========================================
Hits 8555 8555
- Misses 64915 65056 +141
- Partials 9260 9281 +21
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kminoda
reviewed
Oct 5, 2022
IshitaTakeshi
changed the title
Signed-off-by: IshitaTakeshi <ishitah.takeshi@gmail.com>
kminoda
reviewed
Oct 11, 2022
scepter914
pushed a commit
to scepter914/autoware.universe
that referenced
this pull request
Nov 1, 2022
…covariances (autowarefoundation#2018) * Add functions to compute the pose and twist covariances Signed-off-by: IshitaTakeshi <ishitah.takeshi@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: scepter914 <scepter914@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add functions to compute the pose and twist covariances
By making functions we can improve the readability and testability
Related links
Tests performed
Ordinary smoke tests to ensure the generated covariances have expected elements
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.