Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_planning_rviz_plugin): add owner #1953

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 26, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

@yukkysaito
I often change the tier4_planning_rviz_plugin. If you don't mind I can be a coder ower as well.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review September 26, 2022 06:02
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 10.27% // Head: 10.27% // No change to project coverage 👍

Coverage data is based on head (e04ace2) compared to base (78c6638).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1953   +/-   ##
=======================================
  Coverage   10.27%   10.27%           
=======================================
  Files        1148     1148           
  Lines       82071    82071           
  Branches    19084    19084           
=======================================
  Hits         8429     8429           
  Misses      64514    64514           
  Partials     9128     9128           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.25% <ø> (ø) Carriedforward from 78c6638

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit d5610fd into autowarefoundation:main Sep 27, 2022
@takayuki5168 takayuki5168 deleted the feat/tier4-planning-rviz-plugin-owner branch September 27, 2022 08:47
@kenji-miyake
Copy link
Contributor

@takayuki5168 [nits] It's not feat nor owner. It's okay if you'll be careful about it from next time on.

boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Sep 29, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants