fix(raw_vehicle_cmd_converter): inconsitent sign of braking command

[ralwing]

Description

Braking Incosistency in raw_vehicle_cmd_converter
This is copied from the q&a section

What confuses me a lot is the line:

desired_brake_cmd = (acc < 0) ? acc : 0;

which in my opinion is wrong, because it sets negative braking values, moreover it is never positive!
So when convert_brake_cmd is true, the desired_brake_cmd command contains positive values, and when it's false the desired_brake_cmd contains negative values.
Braking command should either be negative, or positive, but nevet both.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• [*] I've confirmed the contribution guidelines.
• [*] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[TakaHoribe]

@ralwing Thank you for your contribution. This fix makes sense to me. The CI failed due to the missing signature in your commit (DCO). Would you fix that?

[ralwing]

Ok, @TakaHoribe. Thanks for pointing that out. I've finally successfully signed-off my commit 🥇 😄

[takayuki5168]

FYI, we can apply DCO without manual git push by

1.pushing Details of DCO's CI

2. then pushing "set DCO to pass" (We can see this button when the DCO fails)

[codecov]

Codecov Report

Base: 10.29% // Head: 10.28% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (601c36d) compared to base (36d9d64).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1945      +/-   ##
==========================================
- Coverage   10.29%   10.28%   -0.01%     
==========================================
  Files        1147     1147              
  Lines       81947    81982      +35     
  Branches    19034    19034              
==========================================
  Hits         8433     8433              
- Misses      64519    64554      +35     
  Partials     8995     8995              

Flag	Coverage Δ		*Carryforward flag
differential	5.16% <0.00%> (?)
total	10.27% <0.00%> (ø)		Carriedforward from 36d9d64

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...c/lanelet2_map_loader/lanelet2_map_loader_node.cpp	0.00% <0.00%> (ø)
planning/obstacle_avoidance_planner/src/node.cpp	0.00% <0.00%> (ø)
vehicle/raw_vehicle_cmd_converter/src/node.cpp	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[TakaHoribe]

LGTM. Thank you @ralwing !