-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(map_loader): split to member functions #1941
refactor(map_loader): split to member functions #1941
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Codecov ReportBase: 10.44% // Head: 10.44% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1941 +/- ##
==========================================
- Coverage 10.44% 10.44% -0.01%
==========================================
Files 1233 1233
Lines 88034 88058 +24
Branches 20501 20501
==========================================
Hits 9197 9197
- Misses 69328 69352 +24
Partials 9509 9509
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@mitsudome-r @TakaHoribe @kenji-miyake Could you review? The reason to split the implementation to some member functions is as follows. I will create a script which uses map_loader as a library and calls these member functions. |
@kenji-miyake Thank you always for your quick review and also further review. |
Signed-off-by: Takayuki Murooka takayuki5168@gmail.com
Description
small refactoring for #1942
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.