-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(obstacle_cruise_planner): ignore behind obstacles #1894
fix(obstacle_cruise_planner): ignore behind obstacles #1894
Conversation
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportBase: 10.44% // Head: 10.41% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1894 +/- ##
==========================================
- Coverage 10.44% 10.41% -0.04%
==========================================
Files 1233 1233
Lines 88027 88323 +296
Branches 20501 20501
==========================================
Hits 9197 9197
- Misses 69319 69615 +296
Partials 9511 9511
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…tion#1894) * fix(obstacle_cruise_planner): ignore behind obstacles Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * fix invalid access Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * update isFrontCollideObstacle Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp>
…tion#1894) * fix(obstacle_cruise_planner): ignore behind obstacles Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * fix invalid access Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * update isFrontCollideObstacle Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
…tion#1894) * fix(obstacle_cruise_planner): ignore behind obstacles Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * fix invalid access Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * update isFrontCollideObstacle Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
…tion#1894) * fix(obstacle_cruise_planner): ignore behind obstacles Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * fix invalid access Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * update isFrontCollideObstacle Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
…tion#1894) * fix(obstacle_cruise_planner): ignore behind obstacles Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * fix invalid access Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * update isFrontCollideObstacle Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Description
The current implementation does not adequately filter backward vehicles, and reacts to backward vehicles in cases such as
following image.
I fixed this by enhancing filtering for backward vehicles out of trajectory.
Related links
Tests performed
With this PR, backward vehicles are ignored properly.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.