Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ground_segmentation): Change ground segmentation parameters #1866

Conversation

djargot
Copy link
Contributor

@djargot djargot commented Sep 14, 2022

Description

This PR changes parameters for ground segmentation algorithm and fixes: #669

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx
Copy link
Contributor

xmfcx commented Sep 20, 2022

@xmfcx
Copy link
Contributor

xmfcx commented Oct 4, 2022

#669 (comment) looking at these results, I think we can merge this PR. Can you remove draft status? Thanks!

@djargot djargot requested a review from xmfcx October 5, 2022 10:16
@djargot djargot marked this pull request as ready for review October 5, 2022 10:19
@yukkysaito
Copy link
Contributor

@badai-nguyen @miursh May I ask for a review?

@miursh
Copy link
Contributor

miursh commented Oct 6, 2022

@xmfcx @djargot
We have developed new option for scan ground filter #1899
You can still use conventional algorithm, but some option parameter is added https://github.com/autowarefoundation/autoware.universe/blob/main/launch/tier4_perception_launch/config/obstacle_segmentation/ground_segmentation/ground_segmentation.param.yaml#L26-L31.

@yukkysaito
Copy link
Contributor

What should we do about this PR?
If no reply within two weeks, I will close it.

@piotr-zyskowski-rai
Copy link

What should we do about this PR? If no reply within two weeks, I will close it.

I believe it can be closed. The issue that this PR was supposed to solve was solved in a different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ground segmentation fails for points behind the low objects
5 participants