Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(signal_processing): add lpf for twist #1852

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 13, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

add lowpass filter for twist

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review September 13, 2022 06:59
Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #1852 (f5fdf83) into main (6075e60) will decrease coverage by 0.08%.
The diff coverage is 29.16%.

@@            Coverage Diff             @@
##             main    #1852      +/-   ##
==========================================
- Coverage   10.38%   10.30%   -0.09%     
==========================================
  Files        1212     1215       +3     
  Lines       87407    88268     +861     
  Branches    20282    20310      +28     
==========================================
+ Hits         9080     9094      +14     
- Misses      68846    69668     +822     
- Partials     9481     9506      +25     
Flag Coverage Δ *Carryforward flag
differential 0.78% <29.16%> (?)
total 10.37% <ø> (ø) Carriedforward from 6075e60

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nal_processing/test/src/lowpass_filter_1d_test.cpp 43.75% <ø> (ø)
common/signal_processing/src/lowpass_filter.cpp 20.00% <20.00%> (ø)
...signal_processing/test/src/lowpass_filter_test.cpp 25.71% <25.71%> (ø)
...ssing/include/signal_processing/lowpass_filter.hpp 100.00% <100.00%> (ø)
planning/obstacle_stop_planner/src/node.cpp 0.00% <0.00%> (ø)
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)
.../obstacle_cruise_planner/src/planner_interface.cpp 0.00% <0.00%> (ø)
...ation_based_planner/optimization_based_planner.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@takayuki5168 takayuki5168 merged commit 3bdbb12 into autowarefoundation:main Sep 13, 2022
@takayuki5168 takayuki5168 deleted the feat/twist-lpf branch September 13, 2022 07:22
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants