Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_perception_launch): add input/pointcloud to ground-segmentation #1833

Merged

Conversation

yukke42
Copy link
Contributor

@yukke42 yukke42 commented Sep 11, 2022

Signed-off-by: yukke42 yusuke.muramatsu@tier4.jp

Description

Add the arg of input/pointcloud to ground_segmentation so that the chane of input/pointcloud in perception.launch.xml is applied to ground_segmentation.py as well.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…tion

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
@yukke42 yukke42 force-pushed the fix-ground-segmentation-input branch from 106e0f6 to 62eaf0d Compare September 11, 2022 11:54
@yukke42 yukke42 changed the title fix(perception_launch): add input/pointcloud to ground-segmentation fix(tier4_perception_launch): add input/pointcloud to ground-segmentation Sep 11, 2022
@yukke42 yukke42 added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Sep 11, 2022
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukke42 yukke42 merged commit cb90855 into autowarefoundation:main Sep 11, 2022
@yukke42 yukke42 deleted the fix-ground-segmentation-input branch September 12, 2022 00:16
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…tion (autowarefoundation#1833)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…tion (autowarefoundation#1833)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…tion (autowarefoundation#1833)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…tion (autowarefoundation#1833)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants