Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dummy_infrastructure): change to multiple virtual signal state outputs #1717

Conversation

YoheiMishina
Copy link
Contributor

@YoheiMishina YoheiMishina commented Aug 29, 2022

Description

Modified to allow multiple states to be delivered to accommodate VTL in scenario simulation.
Added a mode to explore the state of Command.
Sends a state that permits Approve if the state is 1 or more in the Command from the Planner.

Related links

Tests performed

Scenarios involving VTLs were simulated to ensure that the goal was reached.
Screenshot from 2022-08-25 10-22-41

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>
Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>
Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>
@YoheiMishina YoheiMishina force-pushed the feature/update_dummy_infrastracture branch from 5f92822 to f4f4f45 Compare August 29, 2022 06:20
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #1717 (fdd1a89) into main (c0f3507) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1717      +/-   ##
==========================================
- Coverage   10.40%   10.39%   -0.01%     
==========================================
  Files        1218     1218              
  Lines       87550    87597      +47     
  Branches    20511    20511              
==========================================
  Hits         9109     9109              
- Misses      68981    69028      +47     
  Partials     9460     9460              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.38% <0.00%> (ø) Carriedforward from c0f3507

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...dummy_infrastructure/dummy_infrastructure_node.hpp 0.00% <ø> (ø)
..._infrastructure_node/dummy_infrastructure_node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@YoheiMishina YoheiMishina changed the title feat(dummy_infrastructure): Change to multiple virtual signal state outputs feat(dummy_infrastructure): change to multiple virtual signal state outputs Aug 29, 2022
@yabuta yabuta mentioned this pull request Aug 31, 2022
7 tasks

if (use_command_state) {
for (const auto & command : command_array.commands) {
if (command.state >= 1) {
Copy link
Contributor

@tkimura4 tkimura4 Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better to change to this?

command.state >= InfrastructureCommand::REQUESTING

or

command.state != InfrastructureCommand::NONE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks better that way, so I changed it.
1f82970

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>
@YoheiMishina YoheiMishina force-pushed the feature/update_dummy_infrastracture branch from a5cdf3d to 98b4ce1 Compare September 8, 2022 02:43
@YoheiMishina YoheiMishina merged commit f7924de into autowarefoundation:main Sep 8, 2022
@YoheiMishina YoheiMishina deleted the feature/update_dummy_infrastracture branch September 8, 2022 04:01
voltonomous pushed a commit to vautonomous/autoware.universe that referenced this pull request Sep 11, 2022
…utputs (autowarefoundation#1717)

* Added parameter to dummy_infrastructure.param.yaml

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

* Modified dummy infrastructure

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

* Modified dummy infrastructure for multiple commands

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

* update dummy_infrastructure

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…utputs (autowarefoundation#1717)

* Added parameter to dummy_infrastructure.param.yaml

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

* Modified dummy infrastructure

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

* Modified dummy infrastructure for multiple commands

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

* update dummy_infrastructure

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…utputs (autowarefoundation#1717)

* Added parameter to dummy_infrastructure.param.yaml

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

* Modified dummy infrastructure

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

* Modified dummy infrastructure for multiple commands

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

* update dummy_infrastructure

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…utputs (autowarefoundation#1717)

* Added parameter to dummy_infrastructure.param.yaml

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

* Modified dummy infrastructure

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

* Modified dummy infrastructure for multiple commands

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

* update dummy_infrastructure

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…utputs (autowarefoundation#1717)

* Added parameter to dummy_infrastructure.param.yaml

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

* Modified dummy infrastructure

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

* Modified dummy infrastructure for multiple commands

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

* update dummy_infrastructure

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>

Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants