-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dummy_infrastructure): change to multiple virtual signal state outputs #1717
feat(dummy_infrastructure): change to multiple virtual signal state outputs #1717
Conversation
Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>
Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>
Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>
5f92822
to
f4f4f45
Compare
Codecov Report
@@ Coverage Diff @@
## main #1717 +/- ##
==========================================
- Coverage 10.40% 10.39% -0.01%
==========================================
Files 1218 1218
Lines 87550 87597 +47
Branches 20511 20511
==========================================
Hits 9109 9109
- Misses 68981 69028 +47
Partials 9460 9460
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
||
if (use_command_state) { | ||
for (const auto & command : command_array.commands) { | ||
if (command.state >= 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it better to change to this?
command.state >= InfrastructureCommand::REQUESTING
or
command.state != InfrastructureCommand::NONE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks better that way, so I changed it.
1f82970
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>
a5cdf3d
to
98b4ce1
Compare
…utputs (autowarefoundation#1717) * Added parameter to dummy_infrastructure.param.yaml Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> * Modified dummy infrastructure Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> * Modified dummy infrastructure for multiple commands Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> * update dummy_infrastructure Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>
…utputs (autowarefoundation#1717) * Added parameter to dummy_infrastructure.param.yaml Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> * Modified dummy infrastructure Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> * Modified dummy infrastructure for multiple commands Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> * update dummy_infrastructure Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>
…utputs (autowarefoundation#1717) * Added parameter to dummy_infrastructure.param.yaml Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> * Modified dummy infrastructure Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> * Modified dummy infrastructure for multiple commands Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> * update dummy_infrastructure Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>
…utputs (autowarefoundation#1717) * Added parameter to dummy_infrastructure.param.yaml Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> * Modified dummy infrastructure Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> * Modified dummy infrastructure for multiple commands Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> * update dummy_infrastructure Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>
…utputs (autowarefoundation#1717) * Added parameter to dummy_infrastructure.param.yaml Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> * Modified dummy infrastructure Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> * Modified dummy infrastructure for multiple commands Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> * update dummy_infrastructure Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp> Signed-off-by: Yohei MISHINA <yohei.mishina@tier4.jp>
Description
Modified to allow multiple states to be delivered to accommodate VTL in scenario simulation.
Added a mode to explore the state of Command.
Sends a state that permits Approve if the state is 1 or more in the Command from the Planner.
Related links
Tests performed
Scenarios involving VTLs were simulated to ensure that the goal was reached.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.