-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(had_map_utils, tier4_integration_launch)!: remove unused packages #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
mitsudome-r
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #1659 +/- ##
==========================================
+ Coverage 10.66% 10.71% +0.05%
==========================================
Files 1108 1103 -5
Lines 78747 78346 -401
Branches 18640 18640
==========================================
- Hits 8398 8397 -1
+ Misses 61437 61036 -401
- Partials 8912 8913 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
4 tasks
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Sep 28, 2022
autowarefoundation#1659) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 3, 2022
autowarefoundation#1659) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 3, 2022
autowarefoundation#1659) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
yukke42
pushed a commit
to tzhong518/autoware.universe
that referenced
this pull request
Oct 14, 2022
autowarefoundation#1659) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 19, 2022
autowarefoundation#1659) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These packages seem to be unused anymore.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.