Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_avoidance_planner): deal with wider path interval #1616

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Aug 18, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

Fix for obstacle_avoidance_planner to deal with wider (= more than 5.0m) behavior path interval.

Related links

Fix #798
#1369

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #1616 (3eee1ab) into main (9f451b4) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1616      +/-   ##
==========================================
- Coverage   10.77%   10.77%   -0.01%     
==========================================
  Files        1111     1111              
  Lines       78530    78552      +22     
  Branches    18554    18554              
==========================================
  Hits         8464     8464              
- Misses      61206    61228      +22     
  Partials     8860     8860              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.76% <0.00%> (ø) Carriedforward from 3baed53

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/obstacle_avoidance_planner/src/node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@taikitanaka3
Copy link
Contributor

taikitanaka3 commented Aug 18, 2022

@takayuki5168
can you test using manual controller to see if ego paths goal after the goal?
for my test motion planning couldn't work

[ERROR] [component_container_mt-49]: process has died [pid 431036, exit code -6, cmd '/opt/ros/galactic/lib/rclcpp_components/component_container_mt --ros-args -r __node:=motion_planning_container -r __ns:=/planning/scenario_planning/lane_driving/motion_planning --params-file /tmp/launch_params_dcbqhho0'].

motion planning container died
image

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 merged commit 3ed2149 into autowarefoundation:main Aug 19, 2022
@takayuki5168 takayuki5168 deleted the fix/obstacle-avoidance-with-wide-input-interval branch August 19, 2022 00:51
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…#1616)

* fix(obstacle_avoidance_planner): deal with wider path interval

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…#1616)

* fix(obstacle_avoidance_planner): deal with wider path interval

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…#1616)

* fix(obstacle_avoidance_planner): deal with wider path interval

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…arefoundation#1616)

* fix(obstacle_avoidance_planner): deal with wider path interval

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…#1616)

* fix(obstacle_avoidance_planner): deal with wider path interval

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 referenced this pull request in tier4/autoware.universe Nov 11, 2022
* fix(obstacle_avoidance_planner): deal with wider path interval

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
yn-mrse referenced this pull request in tier4/autoware.universe Dec 22, 2022
#180)

* fix(obstacle_avoidance_planner): deal with wider path interval

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Yuma Nihei <yuma.nihei@tier4.jp>
takayuki5168 referenced this pull request in tier4/autoware.universe Apr 28, 2023
* fix(obstacle_avoidance_planner): deal with wider path interval

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Nov 9, 2024
…ty of pass judge for preventing sudden stop (autowarefoundation#1616)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Nov 9, 2024
…ty of pass judge for preventing sudden stop (autowarefoundation#1616)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

obstacle_avoidance_planner dies when the interval of path points is long
2 participants