-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): fix short drivable area bug #1475
fix(behavior_path_planner): fix short drivable area bug #1475
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
I've confirmed that this PR works well with Odaiba and logsim shown in the description. |
Codecov Report
@@ Coverage Diff @@
## main #1475 +/- ##
==========================================
- Coverage 10.16% 10.07% -0.10%
==========================================
Files 1135 1135
Lines 78693 79498 +805
Branches 17886 18506 +620
==========================================
+ Hits 7998 8007 +9
- Misses 63077 63815 +738
- Partials 7618 7676 +58
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix(behavior_path_planner): fix short drivable area bug Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add comment Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…dation#1475) * fix(behavior_path_planner): fix short drivable area bug Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add comment Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* fix(behavior_path_planner): fix short drivable area bug Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add comment Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* fix(behavior_path_planner): fix short drivable area bug Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add comment Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* fix(behavior_path_planner): fix short drivable area bug Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add comment Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…dation#1475) * fix(behavior_path_planner): fix short drivable area bug Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add comment Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* fix(behavior_path_planner): fix short drivable area bug Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add comment Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka takayuki5168@gmail.com
Description
Fix the bug where, when using avoidance in behavior path planner, sometimes the drivable area is shorter than expected. (It is expected to draw lanes whose forward length is 50 [m], and backward length is 5 [m])
before
after
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.