Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix short drivable area bug #1475

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Aug 1, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

Fix the bug where, when using avoidance in behavior path planner, sometimes the drivable area is shorter than expected. (It is expected to draw lanes whose forward length is 50 [m], and backward length is 5 [m])

before
image

after
image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review August 1, 2022 03:09
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168
Copy link
Contributor Author

I've confirmed that this PR works well with Odaiba and logsim shown in the description.

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #1475 (bc90496) into main (2958bfa) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1475      +/-   ##
==========================================
- Coverage   10.16%   10.07%   -0.10%     
==========================================
  Files        1135     1135              
  Lines       78693    79498     +805     
  Branches    17886    18506     +620     
==========================================
+ Hits         7998     8007       +9     
- Misses      63077    63815     +738     
- Partials     7618     7676      +58     
Flag Coverage Δ *Carryforward flag
differential 0.79% <0.00%> (?)
total 10.14% <0.00%> (ø) Carriedforward from b61be5a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)
...ne_module/lane_following/lane_following_module.cpp 0.00% <0.00%> (ø)
...nner/src/scene_module/pull_out/pull_out_module.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)
.../src/scene_module/side_shift/side_shift_module.cpp 0.00% <0.00%> (ø)
.../scene_module/utils/geometric_parallel_parking.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 1.38% <0.00%> (+0.32%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2958bfa...bc90496. Read the comment docs.

Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit cdc120c into autowarefoundation:main Aug 4, 2022
@takayuki5168 takayuki5168 deleted the fix/drivable-area-bug branch August 4, 2022 04:50
taikitanaka3 referenced this pull request in tier4/autoware.universe Aug 4, 2022
* fix(behavior_path_planner): fix short drivable area bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add comment

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
HaoruXue pushed a commit to HaoruXue/autoware.universe that referenced this pull request Aug 10, 2022
…dation#1475)

* fix(behavior_path_planner): fix short drivable area bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add comment

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* fix(behavior_path_planner): fix short drivable area bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add comment

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* fix(behavior_path_planner): fix short drivable area bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add comment

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* fix(behavior_path_planner): fix short drivable area bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add comment

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…dation#1475)

* fix(behavior_path_planner): fix short drivable area bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add comment

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* fix(behavior_path_planner): fix short drivable area bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add comment

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants