Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lanelet2_extension): fix getCurrentLanelets() #1318

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 12, 2022

Signed-off-by: satoshi-ota satoshi.ota928@gmail.com

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logically LGTM (not test)

@satoshi-ota satoshi-ota enabled auto-merge (squash) July 12, 2022 10:29
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #1318 (735c860) into main (f8ba10b) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1318      +/-   ##
========================================
- Coverage   9.49%   9.47%   -0.03%     
========================================
  Files       1096    1096              
  Lines      76293   76468     +175     
  Branches   16990   17109     +119     
========================================
+ Hits        7244    7245       +1     
- Misses     62436   62586     +150     
- Partials    6613    6637      +24     
Flag Coverage Δ *Carryforward flag
differential 2.98% <0.00%> (?)
total 9.47% <0.00%> (ø) Carriedforward from f8ba10b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
map/lanelet2_extension/lib/query.cpp 9.52% <0.00%> (ø)
...city_planner/src/scene_module/blind_spot/scene.cpp 0.00% <0.00%> (ø)
planning/behavior_velocity_planner/src/node.cpp 0.76% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ba10b...735c860. Read the comment docs.

@satoshi-ota satoshi-ota merged commit 4c76f99 into autowarefoundation:main Jul 12, 2022
tkimura4 referenced this pull request in tier4/autoware.universe Jul 13, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota deleted the fix/lanelet-extension branch July 13, 2022 06:03
kosuke55 referenced this pull request in tier4/autoware.universe Jul 14, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
s-azumi referenced this pull request in tier4/autoware.universe Sep 6, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
s-azumi referenced this pull request in tier4/autoware.universe Sep 6, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…#1318)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants